Show a warning if a script modifies a non-joined player

[Necktrox]

Issue: 9610: Setting player name in an onPlayerConnect event handler results in desync

[qaisjp]

Instead of adding VerifyPlayerIsJoinedUsage into every method in the Player -> Ped -> Element tree, would it be possible to inject it?

The fact that almost all element/ped/player Lua functions are in their own class should make this easier.

Also, perhaps rename VerifyPlayerIsJoinedUsage to VerifyPlayerJoined or CheckPlayerJoined?

[Necktrox]

Not every method changes the CPlayer (e. g. all the GetPlayerFoo) - I checked all the methods to be sure and only included the call in the methods, which actually modify the player.

A function name should be clear and tell what it does without looking into the code. My added function checks if the element is a player and if the player has joined the game (isJoined). I have nothing against changing the name, because I don't really like the name, but it should include "Print" and/or "Warn".

[qaisjp]

Fair point about the getters. 👍

…

On Tue, 30 May 2017 at 21:45 Marek Kulik ***@***.***> wrote: Not every method changes the CPlayer (e. g. all the GetPlayerFoo) - I checked all the methods to be sure and only included the call in the methods, which actually modify the player. A function name should be clear and tell what it does without looking into the code. My added function checks if the element is a player and if the player has joined the game (isJoined). I have nothing against changing the name, because I don't really like the name, but it should include "Print" and/or "Warn". — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#145 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4WaveyBe_96hhKnouR_xCrib5dWQe5ks5r_H_LgaJpZM4Noxto> .

[qaisjp]

@Necktrox feel free to merge this if you've tested it 👍