Revert "Add final to all public CPacket inheriting classes (#1790)" #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tauto#1790)" This reverts commit bd89570.
qaisjp
approved these changes
Nov 25, 2020
|
Can I debug the dump? |
ghost
merged commit 
Crash dumps only contain the relevant info regarding the crash. You can see everything you need in the screenshot. If you still need more info, you can ask me. |
|
Yeah, um I wonder what the other values are? |
In crash dumps from release builds, you can't see all local variables. They get optimized away. |
Pirulax
added a commit
to Pirulax/mtasa-blue
that referenced
this pull request
Nov 29, 2020
Pirulax
added a commit
that referenced
this pull request
Dec 2, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new packet crash in nightly. Reverting this commit might fix it.