Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Unifont from 5.1 to 13.0.04 #1980

Merged
merged 4 commits into from Jan 6, 2021
Merged

Update Unifont from 5.1 to 13.0.04 #1980

merged 4 commits into from Jan 6, 2021

Conversation

patrikjuvonen
Copy link
Contributor

@patrikjuvonen patrikjuvonen commented Jan 4, 2021 •
edited

Summary

@patrikjuvonen patrikjuvonen added enhancement New feature or request upstream Related to vendor library labels Jan 4, 2021
@patrikjuvonen patrikjuvonen added this to the Confirmed Issues milestone Jan 4, 2021
@patrikjuvonen patrikjuvonen mentioned this pull request Jan 4, 2021
Closed
@patrikjuvonen patrikjuvonen modified the milestones: Confirmed Issues, 1.6 Jan 4, 2021
@sbx320
Copy link
Member

sbx320 commented Jan 4, 2021

Wouldn't it be easier to add this to install_data rather than to add another buildaction?

@patrikjuvonen
Copy link
Contributor Author

Wouldn't it be easier to add this to install_data rather than to add another buildaction?

I thought about it, but I'm sort of conflicted. Currently install_data mostly affects netc pretty much so adding Unifont stands out as an odd one, but I don't know. I could move it.

Dutchman101
Dutchman101 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@Dutchman101 Dutchman101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it available to scripts is pretty nice as well!

botder
botder approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@botder botder left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the font with a regular GUI label (height: 15) and here are the results:
Font size 9 and aliasing-enabled are the defaults for unifont.

grafik

@patrikjuvonen patrikjuvonen marked this pull request as draft January 6, 2021 15:42
@patrikjuvonen patrikjuvonen marked this pull request as ready for review January 6, 2021 15:44
@patrikjuvonen patrikjuvonen added this to In progress in Vendor upgrades via automation Jan 6, 2021
@patrikjuvonen patrikjuvonen merged commit 7528ff5 into multitheftauto:master Jan 6, 2021
Vendor upgrades automation moved this from In progress to Done Jan 6, 2021
@patrikjuvonen patrikjuvonen deleted the vendor/unifont-13.0.04 branch January 6, 2021 19:01
sbx320 pushed a commit that referenced this pull request Jan 7, 2021
@patrikjuvonen @sbx320
Revert "Update Unifont from 5.1 to 13.0.04 (#1980)"
d2cb977 
This reverts commit 7528ff5.
patrikjuvonen added a commit that referenced this pull request Jan 7, 2021
@patrikjuvonen
Revert "Revert "Update Unifont from 5.1 to 13.0.04 (#1980)""
874b6c6 
This reverts commit 50e3299.
ccw808 added a commit to ccw808/mtasa-blue that referenced this pull request Jan 8, 2021
@ccw808
Update Unifont from 5.1 to 13.0.04 (multitheftauto#1980)
cc8f49f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dutchman101 Dutchman101 Dutchman101 approved these changes

@botder botder botder approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request upstream Related to vendor library
Projects
Vendor upgrades
Done
Milestone
1.5.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patrikjuvonen @sbx320 @Dutchman101 @botder