Skip to content

Conversation

Dutchman101
Copy link
Member

@Dutchman101 Dutchman101 commented Nov 27, 2020

This PR updates Unifont from version 5.1 (2008) to 13.0.04 (Nov 2020)

There's no reason not to update, it's tested and works fine, and in fact looks a little better overall. #1864 (comment) inspired this PR.

@Dutchman101
Copy link
Member Author

For verification purposes, the official source of Unifont is http://unifoundry.com/unifont/index.html and the release information for this .ttf is found under "21 November 2020 Release (Unifont 13.0.04)" on said page, and so is the download.

@StrixG StrixG added the upstream Related to vendor library label Nov 27, 2020
@Pirulax
Copy link
Contributor

Pirulax commented Nov 27, 2020

Didn't try it, but lgtm.

Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can find a better solution than uploading a 11.7 MB font to Git. Hmm. We should think about this.

@Pirulax
Copy link
Contributor

Pirulax commented Nov 27, 2020

Well, the whole repo is 600-700 megs, so + 6 megs won't make a difference imho.
These fonts need to be downloaded anyways.
But if we really don't want to host them on git, we could move it into install_data.bat

@CrosRoad95
Copy link

+11.7MB but -15.6MB, so worth

@qaisjp
Copy link
Contributor

qaisjp commented Nov 27, 2020

Well, the whole repo is 600-700 megs, so + 6 megs won't make a difference imho.
These fonts need to be downloaded anyways.
But if we really don't want to host them on git, we could move it into install_data.bat

It adds up. Git is not built for binary files!

+11.7MB but -15.6MB, so worth

This makes no sense. Both files are kept in history

@Pirulax
Copy link
Contributor

Pirulax commented Nov 27, 2020

Ah, good point.
Should we use install_data for fonts then?

@qaisjp
Copy link
Contributor

qaisjp commented Nov 27, 2020

Yes, I think install_data will work. Should we host it on GitHub in a separate repo or upload it to mta servers?

@Pirulax
Copy link
Contributor

Pirulax commented Nov 27, 2020

Well, everything seems to be on MTA's servers (netc, etc..), sooo.
Is there any advantage in using a repo for the files?

@qaisjp
Copy link
Contributor

qaisjp commented Nov 27, 2020

Well, everything seems to be on MTA's servers (netc, etc..), sooo.
Is there any advantage in using a repo for the files?

Helps ensure reproducible builds and better tracking of uploaded files. Note that the (now removed) discord DLLs pull from GitHub!

@qaisjp
Copy link
Contributor

qaisjp commented Nov 28, 2020

@sbx320
Copy link
Member

sbx320 commented Nov 30, 2020

If we want this to be versioned in git, we could use submodules + individual repos per update.

@Pirulax
Copy link
Contributor

Pirulax commented Nov 30, 2020

Just don't forget to add the sub module init steps to readme.md.
We could add a fetch_repo.sh file that would:

git fetch
git pull
git submodule update

@qaisjp
Copy link
Contributor

qaisjp commented Nov 30, 2020

Yeah there's lots of guidance on how to implement this with submodules in #319

@Dutchman101
Copy link
Member Author

How to proceed, or incorporate (e.g pull from) https://github.com/multitheftauto/unifont/ in this PR? I don't really get it.

What exactly does someone need to do for Unifont to get updated? Does it have to do with creating an install-date procedure or premake script that pulls directly from unifont repo? Then i gotta say it's not my thing, so someone that has experience with it feel free to add those changes to this PR (or create a new PR).

@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Dec 30, 2020
@patrikjuvonen patrikjuvonen added this to the 1.6 milestone Dec 30, 2020
@patrikjuvonen patrikjuvonen self-assigned this Dec 30, 2020
@patrikjuvonen patrikjuvonen marked this pull request as draft December 30, 2020 17:45
@patrikjuvonen
Copy link
Contributor

Follow up PR at #1980

@patrikjuvonen patrikjuvonen removed this from the 1.6 milestone Jan 4, 2021
@patrikjuvonen patrikjuvonen removed their assignment Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream Related to vendor library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants