-
-
Notifications
You must be signed in to change notification settings - Fork 488
Update Unifont from 5.1 to 13.0.04 #1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For verification purposes, the official source of Unifont is http://unifoundry.com/unifont/index.html and the release information for this .ttf is found under "21 November 2020 Release (Unifont 13.0.04)" on said page, and so is the download. |
Didn't try it, but lgtm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can find a better solution than uploading a 11.7 MB font to Git. Hmm. We should think about this.
Well, the whole repo is 600-700 megs, so + 6 megs won't make a difference imho. |
+11.7MB but -15.6MB, so worth |
It adds up. Git is not built for binary files!
This makes no sense. Both files are kept in history |
Ah, good point. |
Yes, I think install_data will work. Should we host it on GitHub in a separate repo or upload it to mta servers? |
Well, everything seems to be on MTA's servers (netc, etc..), sooo. |
Helps ensure reproducible builds and better tracking of uploaded files. Note that the (now removed) discord DLLs pull from GitHub! |
I've created a repo and release here: https://github.com/multitheftauto/unifont/releases/tag/v13.0.04 Direct download link: https://github.com/multitheftauto/unifont/releases/download/v13.0.04/unifont-13.0.04.ttf |
If we want this to be versioned in git, we could use submodules + individual repos per update. |
Just don't forget to add the sub module init steps to git fetch
git pull
git submodule update |
Yeah there's lots of guidance on how to implement this with submodules in #319 |
How to proceed, or incorporate (e.g pull from) https://github.com/multitheftauto/unifont/ in this PR? I don't really get it. What exactly does someone need to do for Unifont to get updated? Does it have to do with creating an install-date procedure or premake script that pulls directly from unifont repo? Then i gotta say it's not my thing, so someone that has experience with it feel free to add those changes to this PR (or create a new PR). |
Follow up PR at #1980 |
This PR updates Unifont from version 5.1 (2008) to 13.0.04 (Nov 2020)
There's no reason not to update, it's tested and works fine, and in fact looks a little better overall. #1864 (comment) inspired this PR.