Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the reversed zoom in/out control states in getControlState (#2570) #3467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the reversed zoom in/out control states in getControlState (#2570) #3467

wants to merge 1 commit into from

Conversation

bum8hj
Copy link
Contributor

@bum8hj bum8hj commented Jun 13, 2024

Fixes #2570 (getControlState will return the correct state for zoom_in and zoom_out).
I believe this does not conflict with the changes in #2767

@botder botder added the backwards-incompatible Should be merged after the release of 1.6.1 label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TracerDS TracerDS TracerDS approved these changes

@Nico8340 Nico8340 Nico8340 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backwards-incompatible Should be merged after the release of 1.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getPedControlState returns true for zoom_out when zooming in, and vice versa
4 participants
@bum8hj @TracerDS @Nico8340 @botder