testLineAgainstWater crash fix #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 10, 2019 17:32
Also changed iterator to cleaner one
|
Thank you for the crash fix. I agree we should have a more long-term solution for this, I too feel a boundary check should be unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835
This pull request prevents game crash in some circumstances where new testLineAgainstWater is used. The issue lies in
CWaterManagerSA::GetZonesIntersecting, in some cases when the line checked lies near world boundary, it will try to access zone that lies outside of it. While I don't yet know why it happens, and probably should look into another algorithm for checking which grid cells line travels through, this additional check mitigates the issue.