Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly treat commitSnapshot error #4513

Merged
merged 6 commits into from
Sep 30, 2022

Conversation

BeniaminDrasovean
Copy link
Contributor

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • If the node is closing during a trie snapshot, some nodes will not be retrieved from storage because the dbs are closed, thus automatically triggering the syncing process for those nodes.

Proposed Changes

  • If the reason for which the nodes can not be retrieved from storage is because the node is closing, do not try to sync those nodes.

Testing procedure

  • Normal testing procedure

@codecov-commenter
Copy link

Codecov Report

Base: 70.73% // Head: 70.74% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c252312) compared to base (f7c9429).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.4.0    #4513      +/-   ##
=============================================
+ Coverage      70.73%   70.74%   +0.01%     
=============================================
  Files            624      624              
  Lines          83297    83304       +7     
=============================================
+ Hits           58916    58936      +20     
+ Misses         19973    19966       -7     
+ Partials        4408     4402       -6     
Impacted Files Coverage Δ
state/accountsDB.go 76.82% <0.00%> (-0.31%) ⬇️
trie/node.go 84.25% <66.66%> (+0.78%) ⬆️
trie/branchNode.go 79.52% <100.00%> (+1.25%) ⬆️
trie/extensionNode.go 72.26% <100.00%> (+1.79%) ⬆️
common/pidQueue.go 93.33% <0.00%> (-3.34%) ⬇️
debug/resolver/interceptorResolver.go 77.77% <0.00%> (-1.34%) ⬇️
consensus/broadcast/delayedBroadcast.go 86.21% <0.00%> (+1.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@BeniaminDrasovean BeniaminDrasovean merged commit 63ccf82 into rc/v1.4.0 Sep 30, 2022
@BeniaminDrasovean BeniaminDrasovean deleted the missing-nodes-edgecase-fix branch September 30, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants