Feat/sync missing trie nodes #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
propagate getNodeFromDb err
…-missing-trie-nodes Merge rc v1.4.0 feat sync missing trie nodes
Add identifer in tsm
…in-feat/balance-data-trie-23may # Conflicts: # factory/processing/blockProcessorCreator.go # factory/processing/blockProcessorCreator_test.go # factory/processing/export_test.go # factory/processing/processComponents.go # go.mod # go.sum
…eat/balance-data-trie-23may
…nce-data-trie-23may Merge rc/v1.6.0 in feat/sync missing trie nodes 23may
fix race condition in test
gabi-vuls
previously approved these changes
May 24, 2023
There was a problem hiding this comment.
System test passed.
@@ Log scanner @@
sync-missing-trie-nodes
================================================================================
- Known Warnings 9
- New Warnings 3
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 7844
- wrong nonce in block 2827
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
…c-missing-trie-nodes proper release
iulianpascalau
approved these changes
May 24, 2023
sstanculeanu
approved these changes
May 24, 2023
gabi-vuls
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure