Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove warn #4993

Merged
merged 2 commits into from Feb 16, 2023
Merged

FIX: Remove warn #4993

merged 2 commits into from Feb 16, 2023

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Feb 16, 2023

Reasoning behind the pull request

  • In the old version when there was a fix for FixWaitingList which was wrongfully using a previousEpochConfig for leaving nodes, there was a log.Warn in case of shard mismatch. The reason why this warn was not triggered when nodes were starting with previousConfig from epoch = 0 is because we never changed the number of shards. This warn was adapted to work with metablock start of epoch data which might not provide enough info and trigger unnecessary warnings.

Proposed changes

  • Remove warn

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Feb 16, 2023
@mariusmihaic mariusmihaic marked this pull request as ready for review February 16, 2023 10:00
Base automatically changed from merge-rc-v1-5-0-into-stakingv4-16-feb-2023 to feat/staking-v4 February 16, 2023 11:16
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/staking-v4@3ec82cb). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 63ed5e8 differs from pull request most recent head 85acd2c. Consider uploading reports for the commit 85acd2c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                Coverage Diff                 @@
##             feat/staking-v4    #4993   +/-   ##
==================================================
  Coverage                   ?   70.74%           
==================================================
  Files                      ?      681           
  Lines                      ?    87774           
  Branches                   ?        0           
==================================================
  Hits                       ?    62096           
  Misses                     ?    21074           
  Partials                   ?     4604           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mariusmihaic mariusmihaic merged commit 8237658 into feat/staking-v4 Feb 16, 2023
@mariusmihaic mariusmihaic deleted the remove-warn branch February 16, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants