Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Remove warn #4993

Merged
merged 2 commits into from
Feb 16, 2023
Merged

FIX: Remove warn #4993

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4157398
FIX: Remove warn
mariusmihaic Feb 16, 2023
85acd2c
Merge branch 'feat/staking-v4' into remove-warn
mariusmihaic Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 1 addition & 10 deletions sharding/nodesCoordinator/indexHashedNodesCoordinator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ func (ihnc *indexHashedNodesCoordinator) EpochStartPrepare(metaHdr data.HeaderHa
return
}

metaBlock, castOk := metaHdr.(*block.MetaBlock)
_, castOk := metaHdr.(*block.MetaBlock)
if !castOk {
log.Error("could not process EpochStartPrepare on nodesCoordinator - not metaBlock")
return
Expand Down Expand Up @@ -620,15 +620,6 @@ func (ihnc *indexHashedNodesCoordinator) EpochStartPrepare(metaHdr data.HeaderHa
return
}

prevNumOfShards := uint32(len(metaBlock.ShardInfo))
if prevNumOfShards != newNodesConfig.nbShards {
log.Warn("number of shards does not match",
"previous epoch", ihnc.currentEpoch,
"previous number of shards", prevNumOfShards,
"new epoch", newEpoch,
"new number of shards", newNodesConfig.nbShards)
}

additionalLeavingMap, err := ihnc.nodesCoordinatorHelper.ComputeAdditionalLeaving(allValidatorInfo)
if err != nil {
log.Error("could not compute additionalLeaving Nodes - do nothing on nodesCoordinator epochStartPrepare")
Expand Down