Coverage for: factory/bootstrap #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5139 +/- ##
=============================================
+ Coverage 70.90% 77.78% +6.87%
=============================================
Files 675 654 -21
Lines 87793 85979 -1814
=============================================
+ Hits 62251 66880 +4629
+ Misses 20864 13911 -6953
- Partials 4678 5188 +510
... and 159 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…into unittests_factory_bootstrap # Conflicts: # factory/bootstrap/bootstrapComponents_test.go
| @@ -82,9 +82,6 @@ func NewBootstrapComponentsFactory(args BootstrapComponentsFactoryArgs) (*bootst | |||
| if args.WorkingDir == "" { | |||
| return nil, errors.ErrInvalidWorkingDir | |||
| } | |||
| if check.IfNil(args.StatusCoreComponents) { | |||
| @@ -29,6 +30,15 @@ func CreateShardCoordinator( | |||
| prefsConfig config.PreferencesConfig, | |||
| log logger.Logger, | |||
| ) (sharding.Coordinator, core.NodeType, error) { | |||
| if check.IfNil(nodesConfig) { | |||
factory/bootstrap/shardingFactory.go
Outdated
| if check.IfNil(nodesConfig) { | ||
| return nil, "", errErd.ErrNilGenesisNodesSetupHandler | ||
| } | ||
| if pubKey == nil { |
There was a problem hiding this comment.
please use check.IfNil
iulianpascalau
previously approved these changes
Apr 3, 2023
sstanculeanu
changed the title
…into unittests_factory_bootstrap # Conflicts: # storage/factory/openStorage.go # storage/factory/openStorage_test.go # storage/latestData/latestDataProvider_test.go
sstanculeanu
changed the title
sstanculeanu
changed the title
ssd04
reviewed
Apr 7, 2023
errors/errors.go
Outdated
| var ErrNilLogger = errors.New("nil logger") | ||
|
|
||
| // ErrNilShuffleOutCloser signals that a nil shuffler out closer has been provided | ||
| var ErrNilShuffleOutCloser = errors.New("nil shuffler out closer") |
There was a problem hiding this comment.
should we go with shuffler out or with shuffle out ?
Comment on lines
489
to
490
| t.Run("NewIndexHashedNodesCoordinator fails should error", func(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
this test name and the previous one have the same name, rename here?
gabi-vuls
previously approved these changes
Apr 18, 2023
There was a problem hiding this comment.
System test passed
@@ Log scanner @@
unittests_factory_bootstrap
================================================================================
- Known Warnings 11
- New Warnings 2
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 2754
- wrong nonce in block 912
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
ssd04
previously approved these changes
Apr 24, 2023
sstanculeanu
dismissed stale reviews from ssd04 and gabi-vuls
The base branch was changed.
…into unittests_factory_bootstrap # Conflicts: # errors/errors.go # storage/errors.go
sstanculeanu
changed the title
iulianpascalau
approved these changes
Apr 25, 2023
ssd04
approved these changes
Apr 25, 2023
gabi-vuls
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?