Coverage for: factory/bootstrap

errors/errors.go

@@ -553,3 +553,9 @@ var ErrNilPeersRatingHandler = errors.New("nil peers rating handler")
 
 // ErrNilPeersRatingMonitor signals that a nil peers rating monitor implementation has been provided
 var ErrNilPeersRatingMonitor = errors.New("nil peers rating monitor")
+
+// ErrNilLogger signals that a nil logger instance has been provided
+var ErrNilLogger = errors.New("nil logger")
+
+// ErrNilShuffleOutCloser signals that a nil shuffle out closer has been provided
+var ErrNilShuffleOutCloser = errors.New("nil shuffle out closer")

factory/bootstrap/bootstrapComponents.go

@@ -85,9 +85,6 @@ func NewBootstrapComponentsFactory(args BootstrapComponentsFactoryArgs) (*bootst
 	if args.WorkingDir == "" {
 		return nil, errors.ErrInvalidWorkingDir
 	}
-	if check.IfNil(args.StatusCoreComponents) {
-		return nil, errors.ErrNilStatusCoreComponents
-	}
 	if check.IfNil(args.StatusCoreComponents.AppStatusHandler()) {
 		return nil, errors.ErrNilAppStatusHandler
 	}
@@ -165,12 +162,15 @@ func (bcf *bootstrapComponentsFactory) Create() (*bootstrapComponents, error) {
 		return nil, err
 	}
 
-	unitOpener := createUnitOpener(
+	unitOpener, err := createUnitOpener(
 		bootstrapDataProvider,
 		latestStorageDataProvider,
 		storage.DefaultEpochString,
 		storage.DefaultShardString,
 	)
+	if err != nil {
+		return nil, err
+	}
 
 	dataSyncerFactory := bootstrap.NewScheduledDataSyncerFactory()
 
@@ -337,7 +337,7 @@ func createUnitOpener(
 	latestDataFromStorageProvider storage.LatestStorageDataProviderHandler,
 	defaultEpochString string,
 	defaultShardString string,
-) storage.UnitOpenerHandler {
+) (storage.UnitOpenerHandler, error) {
 	argsStorageUnitOpener := storageFactory.ArgsNewOpenStorageUnits{
 		BootstrapDataProvider:     bootstrapDataProvider,
 		LatestStorageDataProvider: latestDataFromStorageProvider,

factory/bootstrap/bootstrapComponentsHandler_test.go

@@ -5,8 +5,10 @@ import (
 	"testing"
 
 	errorsErd "github.com/multiversx/mx-chain-go/errors"
+	"github.com/multiversx/mx-chain-go/factory"
 	"github.com/multiversx/mx-chain-go/factory/bootstrap"
 	componentsMock "github.com/multiversx/mx-chain-go/testscommon/components"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -31,18 +33,22 @@ func TestNewBootstrapComponentsFactory_NilFactory(t *testing.T) {
 	require.Equal(t, errorsErd.ErrNilBootstrapComponentsFactory, err)
 }
 
-func TestManagedBootstrapComponents_CheckSubcomponentsNoCreate(t *testing.T) {
+func TestManagedBootstrapComponents_MethodsNoCreate(t *testing.T) {
 	t.Parallel()
 
 	args := componentsMock.GetBootStrapFactoryArgs()
 	bcf, _ := bootstrap.NewBootstrapComponentsFactory(args)
 	mbc, _ := bootstrap.NewManagedBootstrapComponents(bcf)
 	err := mbc.CheckSubcomponents()
-
 	require.Equal(t, errorsErd.ErrNilBootstrapComponentsHolder, err)
+
+	assert.Nil(t, mbc.EpochStartBootstrapper())
+	assert.Nil(t, mbc.EpochBootstrapParams())
+	assert.Nil(t, mbc.Close())
+	assert.Equal(t, factory.BootstrapComponentsName, mbc.String())
 }
 
-func TestManagedBootstrapComponents_Create(t *testing.T) {
+func TestManagedBootstrapComponents_MethodsCreate(t *testing.T) {
 	t.Parallel()
 
 	args := componentsMock.GetBootStrapFactoryArgs()
@@ -54,6 +60,17 @@ func TestManagedBootstrapComponents_Create(t *testing.T) {
 
 	err = mbc.CheckSubcomponents()
 	require.Nil(t, err)
+
+	assert.NotNil(t, mbc.EpochStartBootstrapper())
+	params := mbc.EpochBootstrapParams()
+	require.NotNil(t, mbc)
+	assert.Equal(t, uint32(0), params.Epoch())
+	assert.Equal(t, uint32(0), params.SelfShardID())
+	assert.Equal(t, uint32(2), params.NumOfShards())
+	assert.Nil(t, params.NodesConfig())
+
+	assert.Nil(t, mbc.Close())
+	assert.Equal(t, factory.BootstrapComponentsName, mbc.String())
 }
 
 func TestManagedBootstrapComponents_CreateNilInternalMarshalizer(t *testing.T) {
@@ -84,3 +101,15 @@ func TestManagedBootstrapComponents_Close(t *testing.T) {
 	_ = mbc.Close()
 	require.Nil(t, mbc.EpochBootstrapParams())
 }
+
+func TestManagedBootstrapComponents_IsInterfaceNil(t *testing.T) {
+	t.Parallel()
+
+	mbc, _ := bootstrap.NewManagedBootstrapComponents(nil)
+	require.True(t, mbc.IsInterfaceNil())
+
+	args := componentsMock.GetBootStrapFactoryArgs()
+	bcf, _ := bootstrap.NewBootstrapComponentsFactory(args)
+	mbc, _ = bootstrap.NewManagedBootstrapComponents(bcf)
+	require.False(t, mbc.IsInterfaceNil())
+}