Coverage for: networkGroup, nodeGroup, proofGroup, transactionGroup, validatorGroup, vmValuesGroup #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5184 +/- ##
=============================================
+ Coverage 78.75% 79.01% +0.26%
=============================================
Files 680 680
Lines 88133 88018 -115
=============================================
+ Hits 69406 69550 +144
+ Misses 13502 13259 -243
+ Partials 5225 5209 -16
☔ View full report in Codecov by Sentry. |
sstanculeanu
changed the title
bogdan-rosianu
previously approved these changes
Apr 24, 2023
sstanculeanu
dismissed
bogdan-rosianu’s stale review
The base branch was changed.
sstanculeanu
changed the title
| return expectedMap, nil | ||
| }, | ||
| } | ||
| networkGroup, err := groups.NewNetworkGroup(&facade) |
There was a problem hiding this comment.
L970-L981 function extraction?
bogdan-rosianu
previously approved these changes
Apr 26, 2023
iulianpascalau
previously approved these changes
Apr 27, 2023
gabi-vuls
previously approved these changes
Apr 28, 2023
There was a problem hiding this comment.
System test passed.
@@ Log scanner @@
api_tests_p3
================================================================================
- Known Warnings 9
- New Warnings 2
- Known Errors 0
- New Errors 1
- Panics 0
================================================================================ - block hash does not match 12612
- wrong nonce in block 4068
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
…into api_tests_p3 # Conflicts: # api/mock/facadeStub.go
sstanculeanu
dismissed stale reviews from gabi-vuls and bogdan-rosianu
via
5ba962a
bogdan-rosianu
approved these changes
Apr 28, 2023
gabi-vuls
approved these changes
Apr 28, 2023
iulianpascalau
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?