Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage for: networkGroup, nodeGroup, proofGroup, transactionGroup, validatorGroup, vmValuesGroup #5184

Merged
merged 10 commits into from
Apr 28, 2023
Merged

Coverage for: networkGroup, nodeGroup, proofGroup, transactionGroup, validatorGroup, vmValuesGroup #5184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
151a539
extra tests for networkGroup, nodeGroup, proofGroup, validatorGroup, …
sstanculeanu Apr 20, 2023
02fa72b
extra tests for transactionGroup
sstanculeanu Apr 21, 2023
5c14ecc
Merge branch 'rc/v1.6.0' into api_tests_p3
sstanculeanu Apr 24, 2023
6d9a25e
Merge branch 'rc/v1.6.0' into api_tests_p3
sstanculeanu Apr 25, 2023
7267726
Merge branch 'rc/v1.6.0' into api_tests_p3
sstanculeanu Apr 26, 2023
bf6baec
fixes after review
sstanculeanu Apr 26, 2023
974ee05
Merge branch 'rc/v1.6.0' into api_tests_p3
sstanculeanu Apr 27, 2023
9401e52
Merge branch 'rc/v1.6.0' into api_tests_p3
sstanculeanu Apr 27, 2023
5ba962a
Merge branch 'rc/v1.6.0' of https://github.com/multiversx/mx-chain-go…
sstanculeanu Apr 28, 2023
934b03f
removed duplicated error after merge
sstanculeanu Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions api/groups/addressGroup_test.go
View file
Open in desktop
Expand Up @@ -155,8 +155,6 @@ type codeHashResponse struct {
Code string `json:"code"`
}

var expectedErr = errors.New("expected err")

func TestNewAddressGroup(t *testing.T) {
t.Parallel()

Expand Down
157 changes: 120 additions & 37 deletions api/groups/networkGroup_test.go
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@ import (
"encoding/json"
"errors"
"fmt"
"io"
"io/ioutil"
"math/big"
"net/http"
Expand Down Expand Up @@ -735,7 +736,6 @@ func TestGetGenesisNodes(t *testing.T) {
t.Run("facade error, should fail", func(t *testing.T) {
t.Parallel()

expectedErr := errors.New("expected err")
facade := mock.FacadeStub{
GetGenesisNodesPubKeysCalled: func() (map[uint32][]string, map[uint32][]string, error) {
return nil, nil, expectedErr
Expand Down Expand Up @@ -773,26 +773,21 @@ func TestGetGenesisNodes(t *testing.T) {
Waiting: waiting,
}

facade := mock.FacadeStub{
facade := &mock.FacadeStub{
GetGenesisNodesPubKeysCalled: func() (map[uint32][]string, map[uint32][]string, error) {
return eligible, waiting, nil
},
}

networkGroup, err := groups.NewNetworkGroup(&facade)
require.NoError(t, err)

ws := startWebServer(networkGroup, "network", getNetworkRoutesConfig())

req, _ := http.NewRequest("GET", "/network/genesis-nodes", nil)
resp := httptest.NewRecorder()
ws.ServeHTTP(resp, req)

assert.Equal(t, resp.Code, http.StatusOK)

response := genesisNodesConfigResponse{}
loadResponse(resp.Body, &response)

response := &genesisNodesConfigResponse{}
loadNetworkGroupResponse(
t,
facade,
"/network/genesis-nodes",
"GET",
nil,
response,
)
assert.Equal(t, expectedOutput, response.Data.Nodes)
})
}
Expand All @@ -803,7 +798,6 @@ func TestGetGenesisBalances(t *testing.T) {
t.Run("facade error, should fail", func(t *testing.T) {
t.Parallel()

expectedErr := errors.New("expected err")
facade := mock.FacadeStub{
GetGenesisBalancesCalled: func() ([]*common.InitialAccountAPI, error) {
return nil, expectedErr
Expand Down Expand Up @@ -840,26 +834,21 @@ func TestGetGenesisBalances(t *testing.T) {
},
}

facade := mock.FacadeStub{
facade := &mock.FacadeStub{
GetGenesisBalancesCalled: func() ([]*common.InitialAccountAPI, error) {
return initialAccounts, nil
},
}

networkGroup, err := groups.NewNetworkGroup(&facade)
require.NoError(t, err)

ws := startWebServer(networkGroup, "network", getNetworkRoutesConfig())

req, _ := http.NewRequest("GET", "/network/genesis-balances", nil)
resp := httptest.NewRecorder()
ws.ServeHTTP(resp, req)

assert.Equal(t, resp.Code, http.StatusOK)

response := genesisBalancesResponse{}
loadResponse(resp.Body, &response)

response := &genesisBalancesResponse{}
loadNetworkGroupResponse(
t,
facade,
"/network/genesis-balances",
"GET",
nil,
response,
)
assert.Equal(t, initialAccounts, response.Data.Balances)
})
}
Expand All @@ -870,7 +859,6 @@ func TestGetGasConfigs(t *testing.T) {
t.Run("facade error, should fail", func(t *testing.T) {
t.Parallel()

expectedErr := errors.New("expected err")
facade := mock.FacadeStub{
GetGasConfigsCalled: func() (map[string]map[string]uint64, error) {
return nil, expectedErr
Expand Down Expand Up @@ -907,12 +895,61 @@ func TestGetGasConfigs(t *testing.T) {
common.MetaChainSystemSCsCost: metaChainSystemSCsCost,
}

facade := mock.FacadeStub{
facade := &mock.FacadeStub{
GetGasConfigsCalled: func() (map[string]map[string]uint64, error) {
return expectedMap, nil
},
}

response := &gasConfigsResponse{}
loadNetworkGroupResponse(
t,
facade,
"/network/gas-configs",
"GET",
nil,
response,
)
assert.Equal(t, builtInCost, response.Data.Configs.BuiltInCost)
assert.Equal(t, metaChainSystemSCsCost, response.Data.Configs.MetaChainSystemSCsCost)
})
}

func TestNetworkGroup_UpdateFacade(t *testing.T) {
t.Parallel()

t.Run("nil facade should error", func(t *testing.T) {
t.Parallel()

networkGroup, err := groups.NewNetworkGroup(&mock.FacadeStub{})
require.NoError(t, err)

err = networkGroup.UpdateFacade(nil)
require.Equal(t, apiErrors.ErrNilFacadeHandler, err)
})
t.Run("cast failure should error", func(t *testing.T) {
t.Parallel()

networkGroup, err := groups.NewNetworkGroup(&mock.FacadeStub{})
require.NoError(t, err)

err = networkGroup.UpdateFacade("this is not a facade handler")
require.True(t, errors.Is(err, apiErrors.ErrFacadeWrongTypeAssertion))
})
t.Run("should work", func(t *testing.T) {
t.Parallel()

builtInCost := map[string]uint64{
"val1": 1,
}
expectedMap := map[string]map[string]uint64{
common.BuiltInCost: builtInCost,
}
facade := mock.FacadeStub{
GetGasConfigsCalled: func() (map[string]map[string]uint64, error) {
return expectedMap, nil
},
}
networkGroup, err := groups.NewNetworkGroup(&facade)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L970-L981 function extraction?

require.NoError(t, err)

Expand All @@ -923,15 +960,61 @@ func TestGetGasConfigs(t *testing.T) {
ws.ServeHTTP(resp, req)

assert.Equal(t, resp.Code, http.StatusOK)

response := gasConfigsResponse{}
loadResponse(resp.Body, &response)

assert.Equal(t, builtInCost, response.Data.Configs.BuiltInCost)
assert.Equal(t, metaChainSystemSCsCost, response.Data.Configs.MetaChainSystemSCsCost)

expectedErr := errors.New("expected error")
newFacade := mock.FacadeStub{
GetGasConfigsCalled: func() (map[string]map[string]uint64, error) {
return nil, expectedErr
},
}
err = networkGroup.UpdateFacade(&newFacade)
require.NoError(t, err)

req, _ = http.NewRequest("GET", "/network/gas-configs", nil)
resp = httptest.NewRecorder()
ws.ServeHTTP(resp, req)

loadResponse(resp.Body, &response)
assert.Equal(t, http.StatusInternalServerError, resp.Code)
assert.True(t, strings.Contains(response.Error, expectedErr.Error()))
})
}

func TestNetworkGroup_IsInterfaceNil(t *testing.T) {
t.Parallel()

networkGroup, _ := groups.NewNetworkGroup(nil)
require.True(t, networkGroup.IsInterfaceNil())

networkGroup, _ = groups.NewNetworkGroup(&mock.FacadeStub{})
require.False(t, networkGroup.IsInterfaceNil())
}

func loadNetworkGroupResponse(
t *testing.T,
facade shared.FacadeHandler,
url string,
method string,
body io.Reader,
destination interface{},
) {
networkGroup, err := groups.NewNetworkGroup(facade)
require.NoError(t, err)

ws := startWebServer(networkGroup, "network", getNetworkRoutesConfig())

req, _ := http.NewRequest(method, url, body)
resp := httptest.NewRecorder()
ws.ServeHTTP(resp, req)

assert.Equal(t, http.StatusOK, resp.Code)

loadResponse(resp.Body, destination)
}

func getNetworkRoutesConfig() config.ApiRoutesConfig {
return config.ApiRoutesConfig{
APIPackages: map[string]config.APIPackageConfig{
Expand Down