Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc160 into feat multikey metrics 2023.06.26 #5377

Conversation

sstanculeanu
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

matei-p and others added 30 commits October 7, 2022 15:05
…out-flags

only factory and sc processor V2 without flags - trying PRs
Trying new refactor branch - helping reviewers
# Conflicts:
#	process/smartContract/processProxy/processProxy.go
…tion

separated test proxy process from production one
# Conflicts:
#	process/smartContract/processProxy/processProxy.go
matei-p and others added 23 commits May 25, 2023 16:19
# Conflicts:
#	common/enablers/enableEpochsHandler.go
#	factory/processing/blockProcessorCreator.go
#	genesis/errors.go
#	go.mod
#	go.sum
#	integrationTests/testInitializer.go
#	integrationTests/testSyncNode.go
#	integrationTests/vm/testInitializer.go
#	integrationTests/vm/txsFee/asyncCall_test.go
#	integrationTests/vm/txsFee/relayedBuiltInFunctions_test.go
#	integrationTests/vm/wasm/wasmvm/wasmVM_test.go
#	process/block/baseProcess_test.go
#	process/block/export_test.go
#	process/block/metablock_test.go
#	process/block/shardblock_test.go
#	process/smartContract/process_test.go
# Conflicts:
#	common/enablers/enableEpochsHandler.go
#	genesis/process/genesisBlockCreator.go
#	go.mod
#	go.sum
#	integrationTests/testProcessorNode.go
#	process/transaction/shardProcess_test.go
…into merge_rc160_into_feat_multikey_metrics_2023.06.26
@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Jun 26, 2023
@sstanculeanu sstanculeanu self-assigned this Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 70.19% and project coverage change: -0.25 ⚠️

Comparison is base (978029b) 80.30% compared to head (5b36ddf) 80.06%.

❗ Current head 5b36ddf differs from pull request most recent head 1c554d3. Consider uploading reports for the commit 1c554d3 to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/multikey_metrics    #5377      +/-   ##
=========================================================
- Coverage                  80.30%   80.06%   -0.25%     
=========================================================
  Files                        697      705       +8     
  Lines                      90391    92790    +2399     
=========================================================
+ Hits                       72593    74290    +1697     
- Misses                     12626    13186     +560     
- Partials                    5172     5314     +142     
Impacted Files Coverage Δ
cmd/assessment/benchmarks/erc20Benchmark.go 0.00% <ø> (ø)
cmd/assessment/benchmarks/wasmBenchmark.go 0.00% <ø> (ø)
factory/core/coreComponentsHandler.go 80.82% <0.00%> (-2.28%) ⬇️
genesis/process/genesisBlockCreator.go 65.76% <0.00%> (-0.36%) ⬇️
process/common.go 73.92% <0.00%> (-1.08%) ⬇️
...ess/smartContract/processProxy/testProcessProxy.go 0.00% <0.00%> (ø)
process/smartContract/scrCommon/common.go 0.00% <0.00%> (ø)
vm/process/systemVM.go 60.00% <ø> (ø)
process/smartContract/hooks/blockChainHook.go 92.64% <6.25%> (-3.10%) ⬇️
...ocess/smartContract/processorV2/testScProcessor.go 10.29% <10.29%> (ø)
... and 27 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sstanculeanu sstanculeanu merged commit c54fdb2 into feat/multikey_metrics Jun 26, 2023
4 checks passed
@sstanculeanu sstanculeanu deleted the merge_rc160_into_feat_multikey_metrics_2023.06.26 branch June 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants