[chain_simulator] Enable http server option #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiu96
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/test-only-processor-node #5699 +/- ##
=================================================================
- Coverage 79.06% 78.89% -0.18%
=================================================================
Files 728 729 +1
Lines 95517 95721 +204
=================================================================
- Hits 75519 75516 -3
- Misses 14638 14846 +208
+ Partials 5360 5359 -1 ☔ View full report in Codecov by Sentry. |
| @@ -38,7 +38,7 @@ type bootstrapComponentsHolder struct { | |||
| } | |||
|
|
|||
| // CreateBootstrapComponentHolder will create a new instance of bootstrap components holder | |||
| func CreateBootstrapComponentHolder(args ArgsBootstrapComponentsHolder) (factory.BootstrapComponentsHolder, error) { | |||
| func CreateBootstrapComponentHolder(args ArgsBootstrapComponentsHolder) (factory.BootstrapComponentsHandler, error) { | |||
There was a problem hiding this comment.
Please rename to CreateBootstrapComponents and remove the inner closeHandler declaration & usage
| @@ -46,7 +46,7 @@ type cryptoComponentsHolder struct { | |||
| } | |||
|
|
|||
| // CreateCryptoComponentsHolder will create a new instance of cryptoComponentsHolder | |||
| func CreateCryptoComponentsHolder(args ArgsCryptoComponentsHolder) (factory.CryptoComponentsHolder, error) { | |||
| func CreateCryptoComponentsHolder(args ArgsCryptoComponentsHolder) (factory.CryptoComponentsHandler, error) { | |||
There was a problem hiding this comment.
Please rename to CreateCryptoComponents
| @@ -25,7 +25,7 @@ type dataComponentsHolder struct { | |||
| } | |||
|
|
|||
| // CreateDataComponentsHolder will create the data components holder | |||
| func CreateDataComponentsHolder(args ArgsDataComponentsHolder) (factory.DataComponentsHolder, error) { | |||
| func CreateDataComponentsHolder(args ArgsDataComponentsHolder) (factory.DataComponentsHandler, error) { | |||
There was a problem hiding this comment.
Please rename to CreateDataComponents and remove the inner closeHandler declaration & usage
| @@ -27,7 +27,7 @@ type networkComponentsHolder struct { | |||
| } | |||
|
|
|||
| // CreateNetworkComponentsHolder creates a new networkComponentsHolder instance | |||
| func CreateNetworkComponentsHolder(network SyncedBroadcastNetworkHandler) (*networkComponentsHolder, error) { | |||
| func CreateNetworkComponentsHolder(network SyncedBroadcastNetworkHandler) (factory.NetworkComponentsHandler, error) { | |||
There was a problem hiding this comment.
Please rename to CreateNetworkComponents and remove the inner closeHandler declaration & usage
| @@ -31,7 +31,7 @@ type stateComponentsHolder struct { | |||
| } | |||
|
|
|||
| // CreateStateComponents will create the state components holder | |||
| func CreateStateComponents(args ArgsStateComponents) (factory.StateComponentsHolder, error) { | |||
| func CreateStateComponents(args ArgsStateComponents) (factory.StateComponentsHandler, error) { | |||
There was a problem hiding this comment.
Please rename to CreateStateComponents and remove the inner closeHandler declaration & usage
| @@ -24,25 +19,41 @@ type statusCoreComponentsHolder struct { | |||
| } | |||
|
|
|||
| // CreateStatusCoreComponentsHolder will create a new instance of factory.StatusCoreComponentsHolder | |||
| func CreateStatusCoreComponentsHolder(cfg config.Config, coreComponents factory.CoreComponentsHolder) (factory.StatusCoreComponentsHolder, error) { | |||
| func CreateStatusCoreComponentsHolder(configs config.Configs, coreComponents factory.CoreComponentsHolder) (factory.StatusCoreComponentsHandler, error) { | |||
There was a problem hiding this comment.
Please rename to CreateStatusCoreComponents and remove the inner closeHandler declaration & usage
| @@ -22,6 +23,8 @@ import ( | |||
|
|
|||
| // ArgsTestOnlyProcessingNode represents the DTO struct for the NewTestOnlyProcessingNode constructor function | |||
| type ArgsTestOnlyProcessingNode struct { | |||
| Configs config.Configs | |||
| // TODO remove the rest of configs because configs contains all of them | |||
There was a problem hiding this comment.
implement TODO now or in the next PR?
| @@ -326,7 +342,11 @@ func (node *testOnlyProcessingNode) GetStateComponents() factory.StateComponents | |||
| return node.StateComponentsHolder | |||
| } | |||
|
|
|||
| func (node *testOnlyProcessingNode) collectClosableComponents() { | |||
| func (node *testOnlyProcessingNode) GetFacadeHandler() shared.FacadeHandler { | |||
| @@ -335,6 +355,10 @@ func (node *testOnlyProcessingNode) collectClosableComponents() { | |||
| node.closeHandler.AddComponent(node.NetworkComponentsHolder) | |||
| node.closeHandler.AddComponent(node.StatusCoreComponents) | |||
| node.closeHandler.AddComponent(node.CoreComponentsHolder) | |||
| node.closeHandler.AddComponent(node.facadeHandler) | |||
| if enableHTTPServer { | |||
There was a problem hiding this comment.
instead of this ugly if, the createHttpServer can return a mock http server if the chain simulator is run without APIs
| @@ -31,6 +31,7 @@ func NewChainSimulator( | |||
| genesisTimestamp int64, | |||
| roundDurationInMillis uint64, | |||
| roundsPerEpoch core.OptionalUint64, | |||
| apiInterface components.APIConfigurator, // interface | |||
There was a problem hiding this comment.
remove // interface ?
| @@ -11,3 +11,7 @@ type SyncedBroadcastNetworkHandler interface { | |||
| GetConnectedPeersOnTopic(topic string) []core.PeerID | |||
| IsInterfaceNil() bool | |||
| } | |||
|
|
|||
| type APIConfigurator interface { | |||
ssd04
reviewed
Nov 13, 2023
|
|
||
| // RestApiInterface will return the api interface for the provided shard | ||
| func (f *fixedPortAPIConfigurator) RestApiInterface(shardID uint32) string { | ||
| return fmt.Sprintf("%s:%d", f.restAPIInterface, f.restAPIInterface[shardID]) |
There was a problem hiding this comment.
Suggested change
| return fmt.Sprintf("%s:%d", f.restAPIInterface, f.restAPIInterface[shardID]) | |
| return fmt.Sprintf("%s:%d", f.restAPIInterface, f.mapShardPort[shardID]) |
?
|
|
||
| // StartPolling will do nothing | ||
| func (s *statusComponentsHolder) StartPolling() error { | ||
| // todo check if this method |
There was a problem hiding this comment.
solve or update this todo message
There was a problem hiding this comment.
removed todo for the monent
| @@ -23,26 +18,45 @@ type statusCoreComponentsHolder struct { | |||
| persistentStatusHandler factory.PersistentStatusHandler | |||
| } | |||
|
|
|||
| // CreateStatusCoreComponentsHolder will create a new instance of factory.StatusCoreComponentsHolder | |||
| func CreateStatusCoreComponentsHolder(cfg config.Config, coreComponents factory.CoreComponentsHolder) (factory.StatusCoreComponentsHolder, error) { | |||
| // CreateStatusCoreComponents will create a new instance of factory.StatusCoreComponentsHolder | |||
There was a problem hiding this comment.
Suggested change
| // CreateStatusCoreComponents will create a new instance of factory.StatusCoreComponentsHolder | |
| // CreateStatusCoreComponents will create a new instance of factory.StatusCoreComponentsHandler |
iulianpascalau
approved these changes
Nov 14, 2023
| @@ -17,5 +17,5 @@ func NewFixedPortAPIConfigurator(restAPIInterface string, mapShardPort map[uint3 | |||
|
|
|||
| // RestApiInterface will return the api interface for the provided shard | |||
| func (f *fixedPortAPIConfigurator) RestApiInterface(shardID uint32) string { | |||
| return fmt.Sprintf("%s:%d", f.restAPIInterface, f.restAPIInterface[shardID]) | |||
| return fmt.Sprintf("%s:%d", f.restAPIInterface, f.mapShardPort[shardID]) | |||
ssd04
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?