-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chain_simulator] Enable http server option #5699
Changes from 2 commits
1882d25
ea14fce
262b991
86a3e17
ce9718a
847b6b3
c71f3fc
90bf06f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,7 @@ type ArgsCoreComponentsHolder struct { | |
} | ||
|
||
// CreateCoreComponentsHolder will create a new instance of factory.CoreComponentsHolder | ||
func CreateCoreComponentsHolder(args ArgsCoreComponentsHolder) (factory.CoreComponentsHolder, error) { | ||
func CreateCoreComponentsHolder(args ArgsCoreComponentsHolder) (factory.CoreComponentsHandler, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please rename to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. renamed |
||
var err error | ||
instance := &coreComponentsHolder{ | ||
closeHandler: NewCloseHandler(), | ||
|
@@ -433,3 +433,18 @@ func (c *coreComponentsHolder) Close() error { | |
func (c *coreComponentsHolder) IsInterfaceNil() bool { | ||
return c == nil | ||
} | ||
|
||
// Create will do nothing | ||
func (c *coreComponentsHolder) Create() error { | ||
return nil | ||
} | ||
|
||
// CheckSubcomponents will do nothing | ||
func (c *coreComponentsHolder) CheckSubcomponents() error { | ||
return nil | ||
} | ||
|
||
// String will do nothing | ||
func (c *coreComponentsHolder) String() string { | ||
return "" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ type cryptoComponentsHolder struct { | |
} | ||
|
||
// CreateCryptoComponentsHolder will create a new instance of cryptoComponentsHolder | ||
func CreateCryptoComponentsHolder(args ArgsCryptoComponentsHolder) (factory.CryptoComponentsHolder, error) { | ||
func CreateCryptoComponentsHolder(args ArgsCryptoComponentsHolder) (factory.CryptoComponentsHandler, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please rename to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. renamed |
||
instance := &cryptoComponentsHolder{} | ||
|
||
cryptoComponentsHandlerArgs := cryptoComp.CryptoComponentsFactoryArgs{ | ||
|
@@ -237,3 +237,23 @@ func (c *cryptoComponentsHolder) Clone() interface{} { | |
func (c *cryptoComponentsHolder) IsInterfaceNil() bool { | ||
return c == nil | ||
} | ||
|
||
// Create will do nothing | ||
func (c *cryptoComponentsHolder) Create() error { | ||
return nil | ||
} | ||
|
||
// CheckSubcomponents will do nothing | ||
func (c *cryptoComponentsHolder) CheckSubcomponents() error { | ||
return nil | ||
} | ||
|
||
// String will do nothing | ||
func (c *cryptoComponentsHolder) String() string { | ||
return "" | ||
} | ||
|
||
// Close will do nothing | ||
func (c *cryptoComponentsHolder) Close() error { | ||
return nil | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ type dataComponentsHolder struct { | |
} | ||
|
||
// CreateDataComponentsHolder will create the data components holder | ||
func CreateDataComponentsHolder(args ArgsDataComponentsHolder) (factory.DataComponentsHolder, error) { | ||
func CreateDataComponentsHolder(args ArgsDataComponentsHolder) (factory.DataComponentsHandler, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please rename to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. renamed |
||
miniBlockStorer, err := args.StorageService.GetStorer(dataRetriever.MiniBlockUnit) | ||
if err != nil { | ||
return nil, err | ||
|
@@ -106,3 +106,18 @@ func (d *dataComponentsHolder) Close() error { | |
func (d *dataComponentsHolder) IsInterfaceNil() bool { | ||
return d == nil | ||
} | ||
|
||
// Create will do nothing | ||
func (d *dataComponentsHolder) Create() error { | ||
return nil | ||
} | ||
|
||
// CheckSubcomponents will do nothing | ||
func (d *dataComponentsHolder) CheckSubcomponents() error { | ||
return nil | ||
} | ||
|
||
// String will do nothing | ||
func (d *dataComponentsHolder) String() string { | ||
return "" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ type networkComponentsHolder struct { | |
} | ||
|
||
// CreateNetworkComponentsHolder creates a new networkComponentsHolder instance | ||
func CreateNetworkComponentsHolder(network SyncedBroadcastNetworkHandler) (*networkComponentsHolder, error) { | ||
func CreateNetworkComponentsHolder(network SyncedBroadcastNetworkHandler) (factory.NetworkComponentsHandler, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please rename to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
messenger, err := NewSyncedMessenger(network) | ||
if err != nil { | ||
return nil, err | ||
|
@@ -125,3 +125,18 @@ func (holder *networkComponentsHolder) Close() error { | |
func (holder *networkComponentsHolder) IsInterfaceNil() bool { | ||
return holder == nil | ||
} | ||
|
||
// Create will do nothing | ||
func (holder *networkComponentsHolder) Create() error { | ||
return nil | ||
} | ||
|
||
// CheckSubcomponents will do nothing | ||
func (holder *networkComponentsHolder) CheckSubcomponents() error { | ||
return nil | ||
} | ||
|
||
// String will do nothing | ||
func (holder *networkComponentsHolder) String() string { | ||
return "" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to
CreateBootstrapComponents
and remove the innercloseHandler
declaration & usageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed