Migrate data trie fix #5849
Merged
Migrate data trie fix #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the migrate func
BeniaminDrasovean
changed the base branch from
master
to
update-master-rc-sirius-patch-2-2023.01.17
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rc/sirius-patch-2 #5849 +/- ##
=====================================================
- Coverage 80.19% 80.18% -0.02%
=====================================================
Files 709 709
Lines 94128 94131 +3
=====================================================
- Hits 75490 75482 -8
- Misses 13292 13300 +8
- Partials 5346 5349 +3 ☔ View full report in Codecov by Sentry. |
AdoAdoAdo
previously approved these changes
Jan 18, 2024
go.mod
Outdated
| @@ -20,7 +20,7 @@ require ( | |||
| github.com/multiversx/mx-chain-logger-go v1.0.13 | |||
| github.com/multiversx/mx-chain-scenario-go v1.2.1 | |||
| github.com/multiversx/mx-chain-storage-go v1.0.14 | |||
| github.com/multiversx/mx-chain-vm-common-go v1.5.10 | |||
| github.com/multiversx/mx-chain-vm-common-go v1.5.11-0.20240118090210-c70b5a1381ed | |||
There was a problem hiding this comment.
let's not forget about the proper release
| dataEntry := dirtyData{ | ||
| value: leafData.Value, | ||
| value: val, |
Base automatically changed from
update-master-rc-sirius-patch-2-2023.01.17
to
rc/sirius-patch-2
January 22, 2024 10:02
iulianpascalau
dismissed
AdoAdoAdo’s stale review
The base branch was changed.
cmd/node/config/enableEpochs.toml
Outdated
| @@ -258,7 +258,7 @@ | |||
| AutoBalanceDataTriesEnableEpoch = 1 | |||
|
|
|||
| # MigrateDataTrieEnableEpoch represents the epoch when the data tries migration is enabled | |||
| MigrateDataTrieEnableEpoch = 999999 | |||
| MigrateDataTrieEnableEpoch = 1 | |||
There was a problem hiding this comment.
put this on epoch 2? Until we release this RC branch, the flags should be >1
go.mod
Outdated
| github.com/multiversx/mx-chain-vm-v1_2-go v1.2.64 | ||
| github.com/multiversx/mx-chain-vm-v1_3-go v1.3.65 | ||
| github.com/multiversx/mx-chain-vm-v1_4-go v1.4.92 | ||
| github.com/multiversx/mx-chain-vm-common-go v1.5.11-0.20240122101533-cc1288fd297e |
AdoAdoAdo
previously approved these changes
Jan 23, 2024
iulianpascalau
approved these changes
Jan 25, 2024
gabi-vuls
approved these changes
Jan 25, 2024
AdoAdoAdo
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?