Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deps: scenario-go 1.3.0, vm 1.5.25, vm 1.4.93 #5854

Closed
wants to merge 1 commit into from

Conversation

andrei-marinica
Copy link
Contributor

Reasoning behind the pull request

Incorporating changes in the scenario-go (Mandos) architecture.

Proposed changes

Updated dependencies to VM testing infrastructure.

Testing procedure

This only affects code used for testing, not production.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d88539) 80.19% compared to head (ca07fc7) 80.15%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           rc/sirius-patch-2    #5854      +/-   ##
=====================================================
- Coverage              80.19%   80.15%   -0.04%     
=====================================================
  Files                    708      708              
  Lines                  94094    94090       -4     
=====================================================
- Hits                   75454    75422      -32     
- Misses                 13295    13325      +30     
+ Partials                5345     5343       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.11-dev-config-ace90ef010 -> scenario-go-update-ca07fc72aa

--- Specific errors ---

block hash does not match 2455
wrong nonce in block 1065
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 267
Nr. of new ERRORS: 0
Nr. of new WARNS: 10
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@iulianpascalau
Copy link
Contributor

iulianpascalau commented Jan 25, 2024

done here #5849, will close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants