-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove environment pollution, other cleanup and simplifications #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove custom support for bash snippets
A bit of workspace cleanup / simplifications
psorinionut
previously approved these changes
Mar 20, 2023
psorinionut
approved these changes
Mar 21, 2023
andrei-marinica
approved these changes
Mar 21, 2023
ovstinga
approved these changes
Mar 21, 2023
CostinCarabas
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1
For less undesired side-effects, the extension does not automatically patch
settings.json
anymore. It's the responsibility of the VSCode user to adjustsettings.json
and include necessary PATHs and variables - only as needed (e.g. if the user does rely on the Rust installation in~/multiversx-sdk
as opposed to a separate installation):For Linux:
For MacOS:
2
Rust-based contract interaction snippets will arise soon.
Writing contract interaction snippets in bash is now discouraged. We've dropped support for invoking such interaction snippets directly from the VSCode extension UI.
Existing bash-based interaction snippets can still be invoked from the CLI, as follows (example for the
adder
contract):3
In the past, we've patched both
launchItems
andtasks
collections oflaunch.json
andtasks.json
. Now we don't anymore.4
Do not patch anymore
.gitignore
. This must be the responsibility of the user (with aid from the contract template system).