ABI/codecs implementation (part 1) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
changed the title
popenta
approved these changes
Jun 6, 2024
| def _do_serialize(self, parts_holder: PartsHolder, input_values: Sequence[Any]): | ||
| for i, value in enumerate(input_values): | ||
| if value is None: | ||
| raise ValueError("cannot serialize nil value") |
There was a problem hiding this comment.
Fixed in #49.
| def _do_deserialize(self, parts_holder: PartsHolder, output_values: Sequence[Any]): | ||
| for i, value in enumerate(output_values): | ||
| if value is None: | ||
| raise ValueError("cannot deserialize into nil value") |
There was a problem hiding this comment.
same comm as above regarding nil
There was a problem hiding this comment.
Fixed in #49.
| https://docs.multiversx.com/developers/data/serialization-overview | ||
| """ | ||
|
|
||
| def __init__(self, parts_separator: str): |
There was a problem hiding this comment.
maybe parts_separator can be @ by default? But i also understand this respects the Go implementation. Not a big deal anyway.
There was a problem hiding this comment.
The @ separator is provided in the higher-level components. For example:
axenteoctavian
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of pull requests.
See: #32.
This can be reviewed side-by-side with: