-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codecs (part 6) - ABI definitions #54
Conversation
|
||
class EndpointDefinition: | ||
def __init__(self, | ||
name: str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also have docs
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
class ParameterDefinition: | ||
def __init__(self, name: str, type: str) -> None: | ||
self.name = name | ||
self.type = type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe (I don't know if those are relevant) multi_arg: bool
for inputs or multi_result: bool
for outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are redundant / not relevant, indeed. Sufficient information is captured in the type expression itself.
This is part of a series of pull requests.
See: #32.
Defines ABI definition concepts, as Python classes.