Codecs (part 7): integration of serializer & ABI into queries controller and contract transactions factory #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
changed the title
andreibancioiu
changed the title
popenta
approved these changes
Jun 10, 2024
| if is_list_of_bytes(args): | ||
| return args | ||
|
|
||
| raise ValueError("cannot encode arguments: when ABI is not available, they must be either typed values or buffers") |
There was a problem hiding this comment.
...typed values or bytes, maybe? (optional)
There was a problem hiding this comment.
Will be applied in the very next PR.
There was a problem hiding this comment.
Fixed here: #57.
| data_parts.append(function) if not data_parts else data_parts.append(arg_to_string(function)) | ||
| data_parts.extend(args_to_strings(arguments)) | ||
| data_parts.extend([arg.hex() for arg in prepared_arguments]) |
There was a problem hiding this comment.
could have been:
data_parts += [arg.hex() for arg in prepared_arguments]just to stay consistent with the other methods, but it's not a big deal, can stay as it is
There was a problem hiding this comment.
Will be applied in the very next PR.
There was a problem hiding this comment.
Fixed here: #57.
axenteoctavian
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of pull requests.
See: #32.