Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v4, part 2: undo breaking changes of (v4) -> (v5), handle workspaces #42

Merged
merged 9 commits into from
Dec 27, 2023
Merged

Fix v4, part 2: undo breaking changes of (v4) -> (v5), handle workspaces #42

merged 9 commits into from
Dec 27, 2023

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Dec 26, 2023 •
edited
Loading

References:

@andreibancioiu andreibancioiu self-assigned this Dec 26, 2023
@andreibancioiu andreibancioiu changed the title Undo breaking changes of (v4) -> (v5) Fix v4, part 2: undo breaking changes of (v4) -> (v5) Dec 26, 2023
@andreibancioiu andreibancioiu changed the title Fix v4, part 2: undo breaking changes of (v4) -> (v5) Fix v4, part 2: undo breaking changes of (v4) -> (v5), handle Cargo.toml and Cargo.lock of workspaces Dec 26, 2023
@andreibancioiu andreibancioiu changed the title Fix v4, part 2: undo breaking changes of (v4) -> (v5), handle Cargo.toml and Cargo.lock of workspaces Fix v4, part 2: undo breaking changes of (v4) -> (v5), handle workspaces Dec 26, 2023
@andreibancioiu andreibancioiu mentioned this pull request Dec 26, 2023
Open
@andreibancioiu andreibancioiu marked this pull request as ready for review December 27, 2023 11:37
@andreibancioiu andreibancioiu mentioned this pull request Dec 27, 2023
Merged
dragos-rebegea
dragos-rebegea previously approved these changes Dec 27, 2023
View reviewed changes
bogdan-rosianu
bogdan-rosianu previously approved these changes Dec 27, 2023
View reviewed changes
Base automatically changed from fix-v4-part-one-bring-main to release/v4 December 27, 2023 13:17
@andreibancioiu andreibancioiu dismissed stale reviews from bogdan-rosianu and dragos-rebegea December 27, 2023 13:17

The base branch was changed.

@andreibancioiu andreibancioiu merged commit 0673893 into release/v4 Dec 27, 2023
2 checks passed
@andreibancioiu andreibancioiu deleted the fix-v4-part-two-undo-breaking-changes branch December 27, 2023 13:29
@andreibancioiu andreibancioiu mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragos-rebegea dragos-rebegea dragos-rebegea approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreibancioiu @dragos-rebegea @bogdan-rosianu