Fix packaging of source code (package whole workspace when needed) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Dec 27, 2023
| @@ -50,7 +50,7 @@ def get_source_code_files( | |||
| files_related_to_contract = set(file.path for file in source_code_files) | |||
|
|
|||
| if include_unrelated_to_contract: | |||
| all_files = get_all_files(contract_folder, _is_source_code_file) | |||
| all_files = get_all_files(project_folder, _is_source_code_file) | |||
There was a problem hiding this comment.
This was a bug. But it didn't manifest, since include_unrelated_to_contract was always False (with the exception of integration tests).
andreibancioiu
commented
Jan 2, 2024
|
|
||
| check_project_folder_and_packaged_src_are_equivalent(project_path, parent_output_using_project, parent_output_using_packaged_src, ["adder", "multisig"]) | ||
| repository_url = "https://github.com/multiversx/mx-reproducible-contract-build-example-sc" | ||
| tag = "0.4.7-beta.1" |
There was a problem hiding this comment.
Will be adjusted at a later time, after this merge, once a proper tag is available.
See: multiversx/mx-deprecated-reproducible-contract-build-example-sc#20
andreibancioiu
changed the title
bogdan-rosianu
approved these changes
Jan 3, 2024
andrei-marinica
approved these changes
Jan 3, 2024
dragos-rebegea
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--package-whole-project-srcflag (exotic use-cases).This allows one to have reproducible builds for contracts that exist within Cargo workspaces that are subject to issue #43.
Related to: #42.