Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.0 #195

Merged
merged 48 commits into from
Apr 29, 2019
Merged

Release v0.9.0 #195

merged 48 commits into from
Apr 29, 2019

Conversation

mum4k
Copy link
Owner

@mum4k mum4k commented Apr 29, 2019

[0.9.0] - 28-Apr-2019

Added

  • The TextInput widget, an input field allowing interactive text input.
  • The Donut widget can now display an optional text label under the donut.

Changed

  • Widgets now get information whether their container is focused when Draw is
    executed.
  • The SegmentDisplay widget now has a method that returns the observed character
    capacity the last time Draw was called.
  • The grid.Builder API now allows users to specify options for intermediate
    containers, i.e. containers that don't have widgets, but represent rows and
    columns.
  • Line chart widget now allows math.NaN values to represent "no value" (values
    that will not be rendered) in the values slice.

Breaking API changes

  • The widgetapi.Widget.Draw method now accepts a second argument which provides
    widgets with additional metadata. This affects all implemented widgets.
  • Termdash now requires at least Go version 1.10, which allows us to utilize
    math.Round instead of our own implementation and strings.Builder instead
    of bytes.Buffer.
  • Terminal shortcuts like Ctrl-A no longer come as two separate events,
    Termdash now mirrors termbox-go and sends these as one event.

mum4k and others added 30 commits April 3, 2019 23:13
Provide metadata to widgets when drawing.
SegmentDisplay now reports its capacity.
Allow options on intermediate containers in the grid.
…e displayed as empty cells

Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Signed-off-by: Xabier Larrakoetxea <slok69@gmail.com>
Allow empty values on line chart
- switching to math.Round and deleting out clone.
- switching all bytes.Buffer instances to strings.Builder.
It makes it hard to recognize when a shortcut is pressed and when a
single character is pressed. Do what termbox does and identify these
separately.

Obsoletes #20.
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mum4k
Copy link
Owner Author

mum4k commented Apr 29, 2019

@slok confirmed and gave permission to push his code into the master branch in #185.

@mum4k mum4k merged commit e6af456 into master Apr 29, 2019
@coveralls
Copy link

coveralls commented Apr 29, 2019

Pull Request Test Coverage Report for Build 1091

  • 733 of 781 (93.85%) changed or added relevant lines in 28 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 92.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/fakewidget/fakewidget.go 8 12 66.67%
widgets/donut/donut.go 48 64 75.0%
widgets/textinput/textinput.go 202 230 87.83%
Files with Coverage Reduction New Missed Lines %
internal/fakewidget/fakewidget.go 2 81.4%
widgets/donut/donut.go 2 82.54%
Totals Coverage Status
Change from base Build 1012: -0.006%
Covered Lines: 7129
Relevant Lines: 7709

💛 - Coveralls

@mum4k mum4k deleted the release-0-9-0 branch April 29, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants