Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles on grid rows #181

Closed
slok opened this issue Apr 7, 2019 · 3 comments
Closed

Titles on grid rows #181

slok opened this issue Apr 7, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@slok
Copy link
Contributor

slok commented Apr 7, 2019

Hi!

Thanks for implementing this awesome library with a well-designed API.

I'm using the grid layout style but I'm missing how to add titles to the rows, I only can add titles to the widgets, and vice-versa (using containers directly I can have titles in rows but not titles on widgets).

Is this possible and I'm missing something?

Thank you!

mum4k added a commit that referenced this issue Apr 7, 2019
@mum4k mum4k added the enhancement New feature or request label Apr 7, 2019
@mum4k mum4k added this to the Release 0.9.0 milestone Apr 7, 2019
@mum4k
Copy link
Owner

mum4k commented Apr 7, 2019

Hi @slok,

thank you very much for the feedback. Your observation is correct, the current implementation of the grid API doesn't allow users to specify options for the intermediate containers.

The good news is that this was fairly easy to add. I have pushed #182 into the devel branch.

I would appreciate if you could try building from the devel branch and let me know if this works as expected.

Jakub

@mum4k mum4k closed this as completed Apr 7, 2019
@slok
Copy link
Contributor Author

slok commented Apr 7, 2019

Wow! that was fast!

I just tested and works like a charm! thanks! :)

@mum4k
Copy link
Owner

mum4k commented Apr 7, 2019

Thanks a lot for confirming, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants