Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(url): Add Mumble URL documentation #199

Merged
merged 4 commits into from
Aug 22, 2023
Merged

docs(url): Add Mumble URL documentation #199

merged 4 commits into from
Aug 22, 2023

Conversation

Kissaki
Copy link
Member

@Kissaki Kissaki commented Aug 20, 2023

Kissaki and others added 3 commits August 21, 2023 20:25
Co-authored-by: Robert Adam <dev@robert-adam.de>
The attribute can reasonably be expected to no longer be necessary.

* No longer document it in the main scheme description
* Document it in a separate, specific backwards compatibility section
@Kissaki
Copy link
Member Author

Kissaki commented Aug 21, 2023

Resolved the three comments. PTAL

@Kissaki Kissaki requested a review from Krzmbrzl August 21, 2023 18:46
Copy link
Member

@Krzmbrzl Krzmbrzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kissaki Kissaki merged commit b743d16 into master Aug 22, 2023
1 check passed
@Kissaki Kissaki deleted the docs/url branch August 22, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants