Skip to content

Commit

Permalink
Do not update fill suggestion on clipboard changes
Browse files Browse the repository at this point in the history
This means the user can not copy a Mumble URL while the dialog is open
and fill in the data from it. Instead, he will have to close and reopen
the dialog.

This change is to prevent potential confusion in case the user reads the
fill suggestion, (briefly) switches tasks, and then has different data
in their clipboard. This would also change the suggested fill data,
potentially without the user noticing the change, and then confusion
about the filled data.
  • Loading branch information
Kissaki committed Nov 11, 2017
1 parent c33f5de commit 2a4413e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/mumble/ConnectDialog.cpp
Expand Up @@ -767,8 +767,6 @@ ConnectDialogEdit::ConnectDialogEdit(QWidget *parent) : QDialog(parent) {
setWindowTitle(tr("Add Server"));
init();

connect(QApplication::clipboard(), SIGNAL(dataChanged()), this, SLOT(updateFromClipboard()));

if (!updateFromClipboard()) {
// If connected to a server assume the user wants to add it
if (g.sh && g.sh->isRunning()) {
Expand Down

0 comments on commit 2a4413e

Please sign in to comment.