Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix recorder crash due to use after free on user object.
The recorder used a ClientUser object pointer attached to the RecordBuffer to be able to access a users session id and username . If the user joined a server, made a noise and immediately left the server before the RecordBuffer from the noise was processed the referenced ClientUser was already deleted which crashed the client. This fix retools RecordInfo and RecordBuffer to carry the information previously needed from the ClientUser so that inside of the recorder thread no dependencies to the ClientUser exist.
- Loading branch information
Showing
2 changed files
with
45 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters