Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OSInfo to identify Windows 8.1 #1048

Closed
mkrautz opened this issue Oct 17, 2013 · 7 comments
Closed

Allow OSInfo to identify Windows 8.1 #1048

mkrautz opened this issue Oct 17, 2013 · 7 comments

Comments

@mkrautz
Copy link
Contributor

mkrautz commented Oct 17, 2013

See http://msdn.microsoft.com/en-us/library/dn302074(v=vs.85).aspx for the changes in Windows 8.1 regarding GetVersion(Ex).

This ticket has been migrated from sourceforge. It is thus missing some details like original creator etc.
The original is at https://sourceforge.net/p/mumble/bugs/1048/ .

@hacst
Copy link
Contributor

hacst commented Nov 7, 2013

Would #178 resolve this issue?

@tipabu
Copy link
Contributor

tipabu commented Nov 8, 2013

Not without changes to src/mumble/mumble.appcompat.manifest. Specifically, it looks like we need to add

<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>

or else 8.1 will identify as 8. We should probably also add

<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>

just to clarify that 8.0 is supported as well. I think adding comments for which OS each GUID corresponds to would probably also be a good idea.

Of course, someone who actually has a Win 8.1 machine should test it and make sure Mumble really is compatible :)

@hacst
Copy link
Contributor

hacst commented Nov 8, 2013

I'm running Windows 8.1 and Mumble works just fine ;)

@bendem
Copy link
Contributor

bendem commented Nov 8, 2013

Same here 😉

tipabu added a commit to tipabu/mumble that referenced this issue Nov 8, 2013
… Coupled with the changes from mumble-voip#178, Win 8.1 should be correctly detected and displayed.
@tipabu
Copy link
Contributor

tipabu commented Nov 8, 2013

I wasn't overly concerned, but neither did I want to claim something I can't test. Thanks for the confirmation.

@mkrautz
Copy link
Contributor Author

mkrautz commented Jan 11, 2014

Thanks @tipabu.

I've pushed your change as 1eefaab.

Closing this bug.

@mkrautz mkrautz closed this as completed Jan 11, 2014
@BeFreeTech
Copy link

I just did a fresh install of windows 8.1, and immediately installed Mumble. The audio wizard produces no sound, and I have my USB headset selected as the output device. I am able to hear all other audio applications on the headphones and even in Mumble I am able to hear the messages spoken. Just no live audio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants