Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Version 1.3 #2728

Closed
EmperorArthur opened this issue Jan 11, 2017 · 97 comments
Closed

Release Version 1.3 #2728

EmperorArthur opened this issue Jan 11, 2017 · 97 comments
Assignees

Comments

@EmperorArthur
Copy link
Contributor

EmperorArthur commented Jan 11, 2017

I'm creating this issue because I haven't seen it discussed anywhere else. If there is an active discussion please post a link to it.

Mumble version 1.3 has plenty of stable features that many users value. It has a dynamic system to keep plugins up to date automatically, channel filters, per user volume controls, etc. Unfortunately, the long time period between stable releases means many users are on version 1.2.

Many users use sites like mumble.com as their download source (It's the first result in a google search for Mumble), and those only serve stable versions. Barring any regressions, a stable 1.3 release should be nothing but a good thing.

Many users are moving to alternative products (Discord) from Mumble. Part of this is discord's web client, and persistent server. Part of it is their, ugly, UI design and the fact the servers are free. But at least part of it is the features discord has and Mumble lacks, like per user volume control.

Releasing a 1.3 stable release will being many new features to the users, and shows that Mumble has an active development community. Given the long time from the 1.2 release I feel that now is the time to proceed. There are only two main questions that need to be answered:

  • When was 1.2 released?
  • Are there any regressions when moving from 1.2 to 1.3?

See Blocker and Critical issues.

@mkrautz
Copy link
Contributor

mkrautz commented Jan 11, 2017

Yeah, we need to do a release soon and get on a proper schedule once again.

The way I see it, there are a few features (SRV records, overlay launcher filter) and a few bug fixes I'd like to get in before we cut a beta, and then we can, IMO, do a release.

@EmperorArthur
Copy link
Contributor Author

EmperorArthur commented Jan 11, 2017

Let's see here.

For overlays, that's Issue #2059, #1953, #1954 and pull #2371.

For SRV records that's #1242, which someone attempted to implement via a QT5 only patch, number #1306.

I think that's it for those two features. Which bugs do you see as blockers?

@mkrautz
Copy link
Contributor

mkrautz commented Jan 11, 2017

Bugs:

#2199 - We need to verify whether the extra locking that was added fixed the problem

#1874 - We need to remove NUL bytes in strings exposed via Ice - or mark some fields as deprecated and add sequence properties for them as an alternative.

@Tarun80
Copy link

Tarun80 commented Jan 12, 2017

@EmperorArthur 1.2.0 came out in 2009-12-10 according to https://wiki.mumble.info/wiki/1.2.0

@mkrautz
Copy link
Contributor

mkrautz commented Jan 12, 2017

The predecessor to 1.3.0 would technically be 1.2.4.
1.3.0 was supposed to be 1.2.5, but we changed the versioning to allow us to release patch releases for 1.2.x for security and bug fixes.

Not that that improves the situation dramatically.

@Kissaki
Copy link
Member

Kissaki commented Jan 12, 2017

Relevant 1.3.0 milestone

@EmperorArthur
Copy link
Contributor Author

There are currently 46 open issues, some of which date back to 2013. Of those, this thread has identified 6 major blockers.

Perfect is the enemy of good enough. To most users the project is stagnant right now. Given that the last stable feature release was 1.2.4 in 2013, I can't blame them.

For example, one feature Discord is touted as having versus Mumble is per channel audio volume. 1.3 has had that for quite a while, but when I checked with everyone I knew who used mumble they were all using 1.2. They didn't even know 1.3 existed, and were wary of trying a "Development Snapshot."

Proposal

I propose that all issues that do not block a 1.3 release be moved from the 1.3 milestone to the 1.4 milestone. This gives everyone a clear indication of things that are major priorities for the project.

@C0rn3j
Copy link

C0rn3j commented Jan 18, 2017

Would be awesome since the 1.2.x branch uses EOL version of Qt at least on Linux.

@EmperorArthur
Copy link
Contributor Author

Wow, I didn't realize QT4's been EOL for an entire year. That's not a happy place for Mumble to be from a security perspective.

http://blog.qt.io/blog/2015/05/26/qt-4-8-7-released/

@jammet
Copy link

jammet commented Jan 19, 2017

I can only encourage you to produce a 1.3 stable release. Everybody I know is enjoying the snapshots, currently.

(Also because every single person I point to the download site doesn't seem to simply FIND the 1.3 release I tell them to download. Either that or they don't find the x64 version ... I'm not making this up :). No idea why, the download section seems to confuse a lot of people, and then I get asked why their overlay isn't working)...

@mkrautz
Copy link
Contributor

mkrautz commented Feb 7, 2017

To provide an update to this, we've created new priority labels on GitHub. See https://wiki.mumble.info/wiki/Issue_Priorities for details.

I've applied labels to all the 1.3.0 milestoned issues. Some of them might be slightly off, but I think most of them are OK.

@mkrautz
Copy link
Contributor

mkrautz commented Feb 13, 2017

The above rules state the in order to release 1.3.0, we have to fix the following bugs:

1.3.0 bugs with priority P0:
https://github.com/mumble-voip/mumble/issues?utf8=%E2%9C%93&q=is%3Aopen%20label%3A%22priority%2FP0%20-%20Blocker%22%20milestone%3A1.3.0

1.3.0 bugs with priority P1:
https://github.com/mumble-voip/mumble/issues?utf8=%E2%9C%93&q=is%3Aopen%20label%3A%22priority%2FP1%20-%20Critical%22%20milestone%3A1.3.0%20

@rburchell
Copy link

It's now approaching a year since this was filed. As a long term software developer and open source contributor, I understand that a lot of work goes into making a high quality release, but I do wonder if that level of concern for high quality can make one overlook other (more immediate) problems.

I recently noticed that 1.2.x was using Qt 4 on Fedora (which as already mentioned is EOL, but also tends to provide a much worse experience[1] in my opinion than Qt 5 running on top of my own work, https://github.com/CrimsonAS/gtkplatform/), so I attempted to build against Qt 5, only to find that the 1.2 release has problems (since fixed I think, from looking around git) that prevent my doing that out of the box, and then found this issue which appears to be in limbo- and with several of the issues linked dating back a number of years, this doesn't look like it is going to be resolved any time soon.

With respect, I would suggest that it may be doing more harm than good in keeping releases in stasis indefinitely. I can't speak for everyone, but as a user, my first experience with Mumble was not a great one, I think it's safe to say, given the amount of work that has gone in since the last 1.2 release. And on the other hand: this also isn't a particularly encouraging state of affairs to me as a potential contributor: I have no desire to work on a release that has no chance of shipping seemingly indefinitely, but nor do I want to perform necromancy and work on an ancient release way behind the "latest" when it's probably not necessary to do so.

I'm not sure what I'm trying to say here, so I guess I'll just cut to it: my personal suggestion would be that getting a release out relatively soon - regardless of the open bug list - would be a good idea. It may have problems, but nothing is insurmountable, and the appearance of a slightly more "blessed" 1.3 that can make its way to end users wouldn't mean that 1.2 would vanish immediately for those that required it.

To make it clear, I mean no disrespect by this comment, I'm very happy to see that there's something open source in this space. I'm new to Mumble, and just felt that my perspective/$0.02 may be worth offering. I hope it's of some use.

[1]: here's a screenshot of a freshly started, connected but otherwise untouched Mumble instance. note the tiny icons, not-quite-native menus, and small window size meaning that text isn't easily visible.

image

@stikonas
Copy link

Also please note, that KDE will soon release 17.12 version of its Applications which no longer ships any Qt4 based applications. After this, most GNU/Linux distributions will simply start cleaning up other unported Qt4 programs. See e.g.

https://wiki.debian.org/Qt4Removal
https://bugs.gentoo.org/631788

@EmperorArthur
Copy link
Contributor Author

Here's the explicit Debian bug about this issue:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874683

@C0rn3j
Copy link

C0rn3j commented Mar 22, 2018

It's now been over a year since this issue was open.

Qt 4 is still EOL, so I will repeat a suggestion in here - how about releasing 1.3 now and moving all current issues to 1.4?

Is there something seriously blocking the 1.3 release?

@ghost
Copy link

ghost commented Mar 22, 2018

Remaining issues for 1.3.0: https://github.com/mumble-voip/mumble/milestone/1

@mkrautz
Copy link
Contributor

mkrautz commented Mar 22, 2018

No, the blockers are the P0 issues.

@killrhythm09
Copy link

So what's holding back progress on the blockers? I'm aware I have no right to complain about the state of the project since I'm not a contributor and it's free software, but as a long-time user of Mumble, it's been frustrating to see all my friends migrate to Discord while things have essentially stagnated here with no stable releases for a number of years. This issue itself is almost a year and a half old.

Is there anything volunteers can do to expedite the process?

@tillschaefer
Copy link

Gentoo is dropping qt4 packages and thus also mumble: https://bugs.gentoo.org/656826

@malteme
Copy link

malteme commented Jun 22, 2018

qt4 support ended two and a half years ago, it's really time to release mumble 1.3.

@C0rn3j
Copy link

C0rn3j commented Jun 22, 2018

So there are currently three blocker (P0) issues - https://github.com/mumble-voip/mumble/issues?q=is%3Aopen+is%3Aissue+label%3A%22priority%2FP0+-+Blocker%22

  1. Which is the correct license? #2071 - two contributors agreed to drop a page from the installer, which would resolve the issue. Seems like a quick fix that's easy enough?
  2. Fix up all dependencies on all OSes to have matching versions and patches. #2865 - Seems like Mumble isn't using current dependency versions and it looks like it's mostly on @mkrautz, asked for status on the issue.
  3. mumble-server installation: Ubuntu 18.04 LTS libzeroc-ice package dependency error #3409 - which seems to be a duplicate of Fix up all dependencies on all OSes to have matching versions and patches. #2865

@LucasToole
Copy link
Contributor

Gentoo Linux has officially masked mumble < 1.3 and USE=mumble, blocking new installations of any version other than the upstream git repo
https://bugs.gentoo.org/656826
https://packages.gentoo.org/packages/media-sound/mumble

@stikonas
Copy link

@Ojoesinco Well, upstream git repo version is also not keyworded. There isn't that much difference for users between masked and not keyworded...

But unfortunately it doesn't look like mumble project cares about being removed from distros :(.

@reelsense
Copy link

@stikonas I've had a very simple PR open since last year... It's a PR that adds a bot to close all this unimportant crap that they don't just make a decision on after X amount of months.

Their indecisiveness is very off-putting. There must be some politics that we're not clued into. I'm closing my PR because I'm tired of looking at it. They can reopen it if someone takes control.

@anarcat anarcat mentioned this issue Feb 14, 2019
@AzP
Copy link

AzP commented Feb 15, 2019

Development snapshots are meant to be on the development edge, fast moving, and temporary. So tagging may not be a good idea. It’ll make our tag list explode.

Development snapshots, yes. I think what @AzP was referring to is tagging a release candidate or a proper release.
Analogouos to what @main-- was referring to, Arch Linux (amongst many other Linux distributions - some already dropped qt4 months ago) is also on its way to deprecating all qt4 related things currently.
Given the fact that two years and nearly 3000 commits have passed since the last stable release, I guess it's not too much to ask for a new stable release tag ;-)
Please do!

What he said! :) 👍 🥇

@Polynomial-C
Copy link

Some Gentoo people actually suggested to make their own snapshot of mumble Git, so they could have a working "release" that could be "keyworded" (~arch, marked for testing) or stabilized (the Git version cannot, since it's constantly changing). Quite a shame that some distribution maintainers would have to do their own "release" due to upstream not making one.

This has now been put into practice:
gentoo/gentoo@deee516
gentoo/gentoo@5446943

@Kissaki
Copy link
Member

Kissaki commented Mar 17, 2019

As a status update: The RC we tagged and then revoked two weeks ago and showed that one of our build scripts did not adequately support git tagged releases. It constructed the version name as if it were a snapshot.

One of our team members was fixing it, but ended up not being able to do so because of time.

Today I fixed it. It has been reviewed and applied.

So I think we are looking at tagging and trigger another RC in the coming days today.

@anarcat
Copy link

anarcat commented Mar 17, 2019

sorry for the +1 and ALL CAPS, but i think it's worth it:

YOU GUYS ROCK! THANKS SO MUCH FOR YOUR WORK!!! :)

@Mikki-black
Copy link

Great to see a 1.3 RC1 but it has almost been 2 months. Is there a blocker issue I missed for not releasing an official 1.3? It would be great to have an official 1.3 release.

@davidebeatrici
Copy link
Member

#3603

@Kissaki
Copy link
Member

Kissaki commented May 19, 2019

To be honest if it's a blocker for Mac, but we have no testers for the PR, we should finish up the release for other platforms and skip Mac. Mac only with no testers available shouldn't be holding up all other platforms (that actually have users and testers).

@davidebeatrici
Copy link
Member

MacStadium kindly provided us a free Mac Mini as part of their open source project: https://www.macstadium.com/opensource

I tested the pull request and reported what has to be fixed: #3603 (comment)

@davidebeatrici
Copy link
Member

RC2 has not been released yet because the signer machine is offline again and unfortunately we're unable to contact @mkrautz.

We already planned to put together a new build infrastructure with Azure Pipelines, but we are currently working on the CMake project (and the new build environment: https://github.com/mumble-voip/mumble-releng-experimental), thus we believe we should wait until it's ready.

I tagged 1.3.0-rc2 and triggered the build, we will manually sign the releases.

@malteme
Copy link

malteme commented Jun 25, 2019

Thanks for keeping us updated.

@davidebeatrici
Copy link
Member

You're welcome.

@Polynomial-C
Copy link

I tagged 1.3.0-rc2 and triggered the build, we will manually sign the releases.

So I suppose we will soon see the same release files like we got for the 1.3.0-rc1 release? I'm especially interested in a mumble-1.3.0-rc2.tar.gz file.

@davidebeatrici
Copy link
Member

Correct. The Windows and macOS files are missing because we have to sign them manually.

mumble-1.3.0-rc2.tar.gz is already available: https://dl.mumble.info/mumble-1.3.0-rc2.tar.gz

It was erroneously called mumble-1.3.0.tar.gz, sorry for that. We have to fix the automated script.

@Polynomial-C
Copy link

Polynomial-C commented Jun 26, 2019

Ah, I was looking here on GitHub in your releases section. Thank you for the link.

@davidebeatrici
Copy link
Member

You're welcome, I uploaded the files on GitHub.

@davidebeatrici
Copy link
Member

1.3.0-rc2 for Windows now available.

@mfr-itr
Copy link

mfr-itr commented Jul 3, 2019

Nice!

@davidebeatrici
Copy link
Member

1.3.0-rc2 for macOS now available.

@Mikki-black
Copy link

Great to see progress on 1.3.0-rc2. Any idea on when the final 1.3 will be released?

@davidebeatrici
Copy link
Member

We are working on the new website, 1.3 will be released as soon as it's ready to be deployed.

You can check out the repository here: https://github.com/mumble-voip/mumble-www

@C0rn3j
Copy link

C0rn3j commented Aug 14, 2019

Why is website redesign blocking the new release?

@davidebeatrici
Copy link
Member

We believe the redesign is mandatory after 1.3 has been so many years under development.

The current website (our Wiki's homepage) is not very clear (e.g. the download links) and it misses quite a few things, such as screenshots and general information about the new version.

@Kissaki
Copy link
Member

Kissaki commented Aug 23, 2019

I cleared out the 1.3.0 milestone (all tickets, which we do not intend to wait for/fix) and added two tickets #3758 and #3759 to make it clear what we intend to do/wait for. This comment is to keep the followers of this ticket updated. :)

I didn’t like either ticket blocking the release. I was initially tempted to just push for a release, no matter the cost or lack of quality. But we need the changelog for a reasonable release, and combining the release with the website release is a chance we should not miss.

We don’t have to make either perfect, as long as it is reasonable and provides good value - which will already be a big improvement to the current state or a release without a reasonable changelog/release change information.

@malteme
Copy link

malteme commented Sep 8, 2019

Mumble 1.3 is finally here!

https://github.com/mumble-voip/mumble/releases/tag/1.3.0

@davidebeatrici
Copy link
Member

And the new website as well!

https://www.mumble.info

@C0rn3j
Copy link

C0rn3j commented Sep 9, 2019

Great job guys!

EDIT: Removed my incorrect statement about deps

@Kissaki Kissaki closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests