server.cpp: Fix comparison between signed and unsigned values #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://msdn.microsoft.com/it-it/library/windows/desktop/ms740516(v=vs.85).aspx Because the SOCKET type is unsigned, MinGW triggers a warning: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] This commit compares the socket to "INVALID_SOCKET" instead of "-1", as recommended by MSDN.
|
I think I would prefer if we just expanded whole function into two separate paths: one for Unix, one for Windows. It's already ifdef-soup. Let me submit a counter-proposal. |
|
See #2801 WDYT? |
|
Reviewed, LGTM. |
|
Closing in favor of #2801 |
|
@davidebeatrici that comment is pretty confusing here. First time I read it I understood that it references another references and not this PR you commented on (even though you can comment over there). But just now I close this, and then got shocked whether I was in the wrong PR. But I was not. ;-) |
|
@Kissaki Sorry, I should have specified that I was talking about mkrautz's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://msdn.microsoft.com/it-it/library/windows/desktop/ms740516(v=vs.85).aspx
Because the SOCKET type is unsigned, MinGW triggers a warning:
This commit compares the socket to "INVALID_SOCKET" instead of "-1", as recommended by MSDN.