Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search field to server list #3532

Closed
k80w opened this issue Oct 10, 2018 · 3 comments · Fixed by #4291
Closed

Add search field to server list #3532

k80w opened this issue Oct 10, 2018 · 3 comments · Fixed by #4291
Labels
client feature-request This issue or PR deals with a new feature good first issue Good for first-time contributors

Comments

@k80w
Copy link

k80w commented Oct 10, 2018

Finding my server with a fresh install of the client can be annoying and would be much less annoying if the user could type its name into a search bar to easily find it.

Rather than simply filtering the server list to only contain server names containing the given search string, it would be nice if it used a fuzzy matching algorithm and returned the most similar results. A very simple way to implement this functionality would be to calculate the Damerau–Levenshtein distance and return the 10 or so least distant results in descending order.

The search results should be displayed in the same area that the current server list resides in, but it would conflict with the server list's tree structure. While searching, rather than displaying servers beneath their country and continent, the list should be flat with the country flags displayed to the left of each individual server.

@Krzmbrzl
Copy link
Member

@Kissaki I guess this could get the feature-request tag and could be added to the feature-project :)

Might also be a good first-issue as this should be fairly easy to implement...

@davidebeatrici davidebeatrici added feature-request This issue or PR deals with a new feature good first issue Good for first-time contributors client labels Sep 10, 2019
@Kissaki Kissaki added this to New in Feature Requests via automation Sep 10, 2019
@Kissaki Kissaki moved this from New to Accepted in Feature Requests Sep 10, 2019
@sakibmahmud
Copy link

Hi, I would like to contribute to this project.

@davidebeatrici
Copy link
Member

Hi, feel free to create a pull request.

Feature Requests automation moved this from Accepted to Discarded Jun 26, 2020
Krzmbrzl added a commit that referenced this issue Jun 26, 2020
This PR revamps the ServerBrowserUI to facilitate its usage. Additionally it also adds a search-functionality to it.

Fixes #3532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature good first issue Good for first-time contributors
Projects
Development

Successfully merging a pull request may close this issue.

4 participants