Fix overlay start #4041
Merged
Fix overlay start #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
force-pushed
the
fix-overlay-start
branch
from
2bd9022
to
492e0b4
Compare
Krzmbrzl
force-pushed
the
fix-overlay-start
branch
2 times, most recently
from
8f941e2
to
e6de917
Compare
…s active Right now the Overlay will start hooking into processes on its construction. This will cause this to happen even if the overlay is actually disabled. This is a rather intrusive behavior and can lead to warnings of the OS (for now macOS only - mumble-voip#3552). This commit refactors the Overlay class so that it will only start hooking into processes, if it is actually enabled (that is setActive is called with true).
As requested in mumble-voip#3515 this commit disables the overlay by default. This is so that Mumbke doesn't try to hook into all system processes for users that don't explicitly want this behavior.
Co-Authored-By: Davide Beatrici <davidebeatrici@gmail.com>
Krzmbrzl
force-pushed
the
fix-overlay-start
branch
from
e1325b0
to
4e08b4a
Compare
|
the latest build is still not running :-( let me know, if you need more information. |
|
Yeah I know. The installer that is currently build on the mac CI is unusable for non-dev systems. This change will be in the 1.3.1 release candidate so you'll be able to test the feature with that :) Thanks for checking up on this though 👍 |
Kissaki
reviewed
Jun 11, 2020
| setActiveInternal(act); | ||
| } | ||
|
|
||
| void Overlay::createPipe() { |
There was a problem hiding this comment.
Regression: createPipe() is introduced but never called.
There was a problem hiding this comment.
Good catch - (hopefully) fixed in #4281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for what is being done.
Fixes #3552
Fixes #3515