Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay does not work anymore in 1.3.1 #4281

Closed
Kissaki opened this issue Jun 11, 2020 · 0 comments · Fixed by #4282
Closed

Overlay does not work anymore in 1.3.1 #4281

Kissaki opened this issue Jun 11, 2020 · 0 comments · Fixed by #4282
Labels
bug A bug (error) in the software client overlay
Milestone
1.3.2

Comments

@Kissaki
Copy link
Member

Kissaki commented Jun 11, 2020 •
edited
Loading

The Overlay does not work anymore in 1.3.1.

Desktop:

  • OS: Windows 10 (should be an issue for all)
  • Version: Mumble 1.3.1

PR #4041 disabled the overlay by default. It includes commit aac3214 which improves the code base, but introduces a regression. In introduces the createPipe method, moves initialization code there but never calls it.
aac3214#diff-bd43cc370108609b2ea02c12eae197c4R226
@Kissaki Kissaki added overlay client bug A bug (error) in the software labels Jun 11, 2020
Krzmbrzl added a commit to Krzmbrzl/mumble that referenced this issue Jun 11, 2020
@Krzmbrzl
FI(overlay): Make overlay work again
b740f12 
In aac3214 Overlay::createPipe() has
been introduced in order to only create the pipe when needed (instead of
in the constructor of the Overlay class). This new function was never
called though which caused the Overlay to stop working.

This commit makes sure the respective function is called when activating
the overlay.

Fixes mumble-voip#4281
Krzmbrzl added a commit to Krzmbrzl/mumble that referenced this issue Jun 11, 2020
@Krzmbrzl
FIX(overlay): Make overlay work again
c5beef9 
In aac3214 Overlay::createPipe() has
been introduced in order to only create the pipe when needed (instead of
in the constructor of the Overlay class). This new function was never
called though which caused the Overlay to stop working.

This commit makes sure the respective function is called when activating
the overlay.

Fixes mumble-voip#4281
@Krzmbrzl Krzmbrzl linked a pull request Jun 11, 2020 that will close this issue
Fix overlay #4282
Merged
@Krzmbrzl Krzmbrzl mentioned this issue Jun 11, 2020
Merged
Krzmbrzl added a commit to Krzmbrzl/mumble that referenced this issue Jun 11, 2020
@Krzmbrzl
FIX(overlay): Make overlay work again
f744e2d 
In aac3214 Overlay::createPipe() has
been introduced in order to only create the pipe when needed (instead of
in the constructor of the Overlay class). This new function was never
called though which caused the Overlay to stop working.

This commit makes sure the respective function is called when activating
the overlay.

Fixes mumble-voip#4281
Krzmbrzl added a commit to Krzmbrzl/mumble that referenced this issue Jun 12, 2020
@Krzmbrzl
FIX(overlay): Make overlay work again
cfe1f6b 
In aac3214 Overlay::createPipe() has
been introduced in order to only create the pipe when needed (instead of
in the constructor of the Overlay class). This new function was never
called though which caused the Overlay to stop working.

This commit makes sure the respective function is called when activating
the overlay.

Fixes mumble-voip#4281
@Kissaki Kissaki added this to the 1.3.2 milestone Jun 12, 2020
This was referenced Jun 14, 2020
Closed
Closed
Closed
@Krzmbrzl Krzmbrzl mentioned this issue Jul 1, 2020
Closed
Krzmbrzl added a commit to Krzmbrzl/mumble that referenced this issue Jul 7, 2020
@Krzmbrzl
FIX(overlay): Make overlay work again
29469ac 
In aac3214 Overlay::createPipe() has
been introduced in order to only create the pipe when needed (instead of
in the constructor of the Overlay class). This new function was never
called though which caused the Overlay to stop working.

This commit makes sure the respective function is called when activating
the overlay.

Fixes mumble-voip#4281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug (error) in the software client overlay
Projects
None yet
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

Fix overlay Krzmbrzl/mumble
1 participant
@Kissaki