Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mumble does not use icon on Plasma under Wayland. #4851

Closed
baduhai opened this issue Mar 11, 2021 · 1 comment · Fixed by #5536
Closed

Mumble does not use icon on Plasma under Wayland. #4851

baduhai opened this issue Mar 11, 2021 · 1 comment · Fixed by #5536
Labels
bug A bug (error) in the software client linux ui

Comments

@baduhai
Copy link

baduhai commented Mar 11, 2021

As the title implies, under Wayland, the icon does not get used. Here's what I looks like:

image

It seems as though notepadqq had the same problem at one point. Specifically due to this:

On X11 the applications exported the window icon as pixmap data. This is no longer possible on Wayland. Instead the compositor maps the window icon from the desktop file and the application announces the desktop file for a window. In Qt this is done by using the reverse domain name combined with the binary name. The domain name is set with KAboutData and defaults to “kde.org”. So for example in the case of kate the desktop file should be called “org.kde.kate.desktop”. So please fix the naming of your desktop files. If you want to test please be aware that this requires Qt 5.5 to work properly.

https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/

The fix seems simple enough, will try to open a pull request when I have some time.

@Krzmbrzl Krzmbrzl added bug A bug (error) in the software client linux ui labels Mar 11, 2021
@Krzmbrzl
Copy link
Member

The only problem I see with this is that ultimately we don't control the name of the desktop file (this is determined by whoever is packaging Mumble for that distro).
However given that we are providing an official desktop file (https://github.com/mumble-voip/mumble/blob/master/scripts/org.mumble_voip.mumble.desktop) I think we should make it work with that one and then a packager has to fix it for themselves if they want to use a different one ☝️

In order to make this work though, we probably have to adapt

mumble/src/mumble/main.cpp

Lines 168 to 170 in 0e376a9

a.setApplicationName(QLatin1String("Mumble"));
a.setOrganizationName(QLatin1String("Mumble"));
a.setOrganizationDomain(QLatin1String("mumble.sourceforge.net"));

as well (which by looking at this now seems like a good idea anyways)

IsSuEat pushed a commit to IsSuEat/mumble that referenced this issue Jan 29, 2022
In a Plasma Wayland session the Mumble icon was not used in the task bar,
instead the generic Wayland icon shows up.
Setting the desktop file name resolves this.

Fixes mumble-voip#4851
Krzmbrzl added a commit that referenced this issue Jan 31, 2022
In a Plasma Wayland session the Mumble icon was not used in the task bar,
instead the generic Wayland icon shows up.
Setting the desktop file name resolves this.

Fixes #4851
Krzmbrzl pushed a commit to Krzmbrzl/mumble that referenced this issue May 8, 2022
In a Plasma Wayland session the Mumble icon was not used in the task bar,
instead the generic Wayland icon shows up.
Setting the desktop file name resolves this.

Fixes mumble-voip#4851

(cherry picked from commit fa88a20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug (error) in the software client linux ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants