FIX(client): Data dir migration issues #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the DB is migrated, it won't be found anymore after a restart, because the new DB location was not saved in the settings. This commit makes sure that during the migration, the path stored in the settings gets updated and then subsequently saved. Because of this, the dedicated migration code block in the Database class is no longer needed (at the point it runs, the DB setting has already been migrated) and was therefore removed.
davidebeatrici
approved these changes
Mar 12, 2022
When migrating the data directory, the plugin settings have been let untouched. However, since these contain the plugin's absolute path (both as a immediate property and also in the hash identifying the plugin), the settings wouldn't apply to the migrated plugins. Therefore, the migration would lead to a loss of plugin settings. This commit adds dedicated code that remedies this situation by explicitly adapting the plugin settings to the migrated plugin paths.
Krzmbrzl
force-pushed
the
fix-db-migration
branch
from
c8416b3
to
50c035b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes related to the migration of the data directory as performed
in #5531.
The following issues are fixed
Checks