Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not ping server which exclusively serve via IPv4 #6349

Closed
Hartmnt opened this issue Feb 28, 2024 · 0 comments · Fixed by #6350
Closed

Can not ping server which exclusively serve via IPv4 #6349

Hartmnt opened this issue Feb 28, 2024 · 0 comments · Fixed by #6350
Labels
bug A bug (error) in the software client

Comments

@Hartmnt
Copy link
Member

Hartmnt commented Feb 28, 2024

Description

Since #5960 the IPv4 representation in the Mumble client is kind of broken. One of the major regressions seems to be that you can no longer ping servers which do not serve via IPv6.

Note: Connecting to IPv4 servers works just fine.

Steps to reproduce

  1. Open the Connect Dialog
  2. Find a server which serves IPv4 but not IPv6
  3. Hover over said server and notice a 100% packet loss
  4. No ping and no user count will be shown

Mumble version

Bisected offending commit is efa8684

Mumble component

Client

OS

Any

Reproducible?

Yes

Additional information

No response

Relevant log output

No response

Screenshots

No response

@Hartmnt Hartmnt added client theme bug A bug (error) in the software and removed theme labels Feb 28, 2024
Hartmnt added a commit to Hartmnt/mumble that referenced this issue Feb 28, 2024
In 6c56568 the HostAddress was refactored. A check for isV6 when
creating a QHostAddress was removed. However, the QHostAddress
determines the (IPv4 vs IPv6) distinction at construction time.
This resulted in some regressions both visually and functional.

This commit reintroduces the distinction.

Fixes mumble-voip#6349
Hartmnt added a commit to Hartmnt/mumble that referenced this issue Feb 28, 2024
In 6c56568 the HostAddress was refactored. A check for isV6 when
creating a QHostAddress was removed. However, the QHostAddress
determines the (IPv4 vs IPv6) distinction at construction time.
This resulted in some regressions both visually and functional.

This commit reintroduces the distinction.

Fixes mumble-voip#6349
Hartmnt added a commit to Hartmnt/mumble that referenced this issue Feb 28, 2024
In 6c56568 the HostAddress was refactored. A check for isV6 when
creating a QHostAddress was removed. However, the QHostAddress
determines the (IPv4 vs IPv6) distinction at construction time.
This resulted in some regressions both visually and functional.

This commit reintroduces the distinction.

Fixes mumble-voip#6349
mryamac pushed a commit to mryamac/mumble that referenced this issue Apr 6, 2024
In 6c56568 the HostAddress was refactored. A check for isV6 when
creating a QHostAddress was removed. However, the QHostAddress
determines the (IPv4 vs IPv6) distinction at construction time.
This resulted in some regressions both visually and functional.

This commit reintroduces the distinction.

Fixes mumble-voip#6349
mryamac pushed a commit to mryamac/mumble that referenced this issue May 21, 2024
In 6c56568 the HostAddress was refactored. A check for isV6 when
creating a QHostAddress was removed. However, the QHostAddress
determines the (IPv4 vs IPv6) distinction at construction time.
This resulted in some regressions both visually and functional.

This commit reintroduces the distinction.

Fixes mumble-voip#6349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug (error) in the software client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant