Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mumble server process name is "Main" #6552

Open
sorcix opened this issue Sep 16, 2024 · 3 comments
Open

Mumble server process name is "Main" #6552

sorcix opened this issue Sep 16, 2024 · 3 comments
Labels
bug A bug (error) in the software good first issue Good for first-time contributors linux server

Comments

@sorcix
Copy link

sorcix commented Sep 16, 2024

Description

On my server, pstree and top identify the mumble-server process as Main instead of mumble-server.

# pstree -p
systemd(1)─┬─Main(506)─┬─{Main}(607)
           │           ├─{Main}(665)
           │           ├─{Main}(666)
           │           └─{Main}(667)
# ps -p 506
    PID TTY          TIME CMD
    506 ?        00:00:00 Main

This PID 506 is actually Mumble server:

# ps aux | grep ' 506 '
_mumble+     506  0.0  2.2 460908 44804 ?        Ssl  13:27   0:00 /usr/bin/mumble-server -ini /etc/mumble/mumble-server.ini -fg

Looks like the thread name is being set in Server.cpp on line 81.

Is it an option to change this to something that indicates it's a Mumble process?

Steps to reproduce

  1. Start a mumble-server instance
  2. Search for the process in pstree/ps/top.

Mumble version

1.5.634

Mumble component

Server

OS

Linux

Reproducible?

Yes

Additional information

No response

Relevant log output

No response

Screenshots

No response

@sorcix sorcix added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Sep 16, 2024
@Hartmnt
Copy link
Member

Hartmnt commented Sep 16, 2024

Yup, I have also noticed this and got annoyed. It seems like this is set by tracy, which is interesting. The easiest fix would indeed be to change the thread name to "mumble-server". I am all for that, but would this break anything @Krzmbrzl ?

@Hartmnt Hartmnt added linux server and removed triage This issue is waiting to be triaged by one of the project members labels Sep 16, 2024
@Krzmbrzl
Copy link
Member

Interesting. Didn't expect for this to have an effect outside of the actual Tracy trace. Renaming to mumble-server should be fine 👍

@Hartmnt
Copy link
Member

Hartmnt commented Sep 16, 2024

@sorcix Would you be able to submit a PR for this?

@Hartmnt Hartmnt added the good first issue Good for first-time contributors label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug (error) in the software good first issue Good for first-time contributors linux server
Projects
None yet
Development

No branches or pull requests

3 participants