Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler.pri: add some of MSVC's -W4 warnings to our build without enabling -W4 itself. #2032

Closed
wants to merge 1 commit into from

Conversation

mkrautz
Copy link
Contributor

@mkrautz mkrautz commented Dec 27, 2015

The added list is not exhaustive. It's just a few that I found
useful while looking.

It might be more sensible to just enable -W4 and disable warnings
instead.

…abling -W4 itself.

The added list is not exhaustive. It's just a few that I found
useful while looking.

It might be more sensible to just enable -W4 and disable warnings
instead.
@mkrautz
Copy link
Contributor Author

mkrautz commented Dec 27, 2015

Not sure we should land this. It is just an experiment I did.

@hacst
Copy link
Contributor

hacst commented Dec 27, 2015

/W4 might be a bit to broad. Have you tried what kind of warnings (and how many) you actually get if you enable it? One big issue with MSVC is that it doesn't have a notion of system headers hence you have a very hard time to keep warnings caused by 3rd party headers out of your compilation.

@mkrautz
Copy link
Contributor Author

mkrautz commented Dec 28, 2015

@mkrautz
Copy link
Contributor Author

mkrautz commented Dec 28, 2015

FWIW, the (possibly incomplete?) warnings list is at:

https://msdn.microsoft.com/en-us/library/cfahxw6k
https://msdn.microsoft.com/en-us/library/ysb0wexw

I will compile a list of all W4 warnings and compare against the real -W4

@davidebeatrici davidebeatrici added the build Everything related to compiling/building the code label Jul 21, 2016
@Krzmbrzl
Copy link
Member

We no longer use the .pri files, so this PR does no longer apply

@Krzmbrzl Krzmbrzl closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Everything related to compiling/building the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants