Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload of Murmur SSL settings via SIGUSR1 (including runtime certificate-swap for Let's Encrypt) #2850

Merged
merged 3 commits into from Mar 5, 2017

Commits on Mar 2, 2017

  1. Meta, UnixMurmur: implement live certificate reloading via the USR1 s…

    …ignal.
    
    This moves the SSL loading code from MetaParams::read() into a separate
    method, loadSSLSettings(). It also hooks up the SIGUSR1 signal handler
    to reload SSL settings and apply the setings to each suitable virtual
    server.
    
    A follow-up commit will change MetaParams::read() to also use loadSSLSettings(),
    however it was left out of this commit to aid in reviewability.
    mkrautz committed Mar 2, 2017
    Copy the full SHA
    fd78d64 View commit details
    Browse the repository at this point in the history
  2. MetaParams: replace SSL settings setup code with a call to loadSSLSet…

    …tings().
    
    This changes MetaParams to use the newly-introduced loadSSLSettings() method
    to load SSL settings.
    mkrautz committed Mar 2, 2017
    Copy the full SHA
    09d4bd3 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2017

  1. Cert: reset Server's SSL state in initializeCert().

    This changes Server::initializeCert() to always reset the
    Server's SSL state before reloading it.
    
    Previously, we didn't reset the state.
    
    Not doing so *does* actually works for the case where we
    load the certificate and key from the per-vserver configuration
    in ServerDB.
    
    However, it doesn't work when reading from Meta, because
    the old Server::initializeCert() would only use the settings
    from Meta if qscCert/qskKey were null.
    mkrautz committed Mar 4, 2017
    Copy the full SHA
    7925c37 View commit details
    Browse the repository at this point in the history