Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay_macx: fix code to work with removal of OverlaySettings::bUseWhitelist. #2975

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/mumble/Overlay_macx.mm
Expand Up @@ -76,12 +76,24 @@ - (void) appLaunched:(NSNotification *)notification {

QString qsBundleIdentifier = QString::fromUtf8([bundleId UTF8String]);

if (g.s.os.bUseWhitelist) {
if (g.s.os.qslWhitelist.contains(qsBundleIdentifier))
overlayEnabled = YES;
} else {
if (! g.s.os.qslBlacklist.contains(qsBundleIdentifier))
switch (g.s.os.oemOverlayExcludeMode) {
case OverlaySettings::LauncherFilterExclusionMode: {
qWarning("Overlay_macx: launcher filter mode not implemented on macOS, allowing everything");
overlayEnabled = YES;
break;
}
case OverlaySettings::WhitelistExclusionMode: {
if (g.s.os.qslWhitelist.contains(qsBundleIdentifier)) {
overlayEnabled = YES;
}
break;
}
case OverlaySettings::BlacklistExclusionMode: {
if (! g.s.os.qslBlacklist.contains(qsBundleIdentifier)) {
overlayEnabled = YES;
}
break;
}
}

if (overlayEnabled) {
Expand Down