PulseAudio: Fixed multi-speaker setup problem - updated #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit has been updated for the second time. If you wonder why I added some empty lines, that is purely for readability. And I found out there is no need for a new pull request, just some comment to get your attention. |
|
Squashed the two commits and change the g.s.doPositionalAudio() to g.s.bEchoMulti for pasSpeaker. |
- The PulseAudio profile for the speakers is now used in mumble. - This also fixed the problem of mumble crashing when using a 7.1 setup. - Cleared some additional QHash's and remove one that was unused. - Assigned the pa_sample_spec in order with the structure(format,rate,channels) - Added multi channel support for echo cancellation.
|
This looks good to go. |
|
Merged, thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the commit. Due to the history change in my git repo, I needed to init a new pull request.