Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Some Issues, Improve Code quality #3051

Merged
merged 8 commits into from Apr 26, 2017
Merged

Fix Some Issues, Improve Code quality #3051

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f814cc5
Use constants instead of magic numbers
Kissaki Apr 25, 2017
03d11d4
Use readable hex version constant for checks
Kissaki Apr 25, 2017
17c7ee0
Check for error on winapi calls
Kissaki Apr 25, 2017
c9d6d91
Check for null before pointer use
Kissaki Apr 25, 2017
386112e
Reduce variable scope
Kissaki Apr 25, 2017
830ea8a
Initialize pointers in constructor
Kissaki Apr 25, 2017
89b1ec2
Add comment for workaround from/as in mumble/main.cpp
Kissaki Apr 25, 2017
ce4e3cf
Check env-var function return values for errors
Kissaki Apr 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mumble/VoiceRecorder.cpp
View file
Open in desktop
Expand Up @@ -294,7 +294,7 @@ bool VoiceRecorder::ensureFileIsOpenedFor(SF_INFO& soundFileInfo, boost::shared_
void VoiceRecorder::run() {
Q_ASSERT(!m_recording);

if (g.sh && g.sh->uiVersion < 0201003)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF? Why did we do this in the first place?!

if (g.sh && g.sh->uiVersion < 0x010203)
return;

SF_INFO soundFileInfo = createSoundFileInfo();
Expand All @@ -307,7 +307,7 @@ void VoiceRecorder::run() {
m_sleepLock.lock();
m_sleepCondition.wait(&m_sleepLock);

if (!m_recording || m_abort || (g.sh && g.sh->uiVersion < 0201003)) {
if (!m_recording || m_abort || (g.sh && g.sh->uiVersion < 0x010203)) {
m_sleepLock.unlock();
break;
}
Expand Down