Switch client DB to sqlite synchronization mode NORMAL #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacst
force-pushed
the
clientdbdurability
branch
from
a2be882
to
222d9df
Compare
In a userbase of primarily gamers system instabilities aren't that uncommon. Without synchronization of the user-db this can lead to corruption of our client database storing the user-certificate. We have had various reports of such issues over time. The current mode was set in 2010 in commit 9fee66e to speed up the client-db "even more" though it is unclear whether we actually had performance problems that required this step. This patch switches the client synchronization mode from OFF to NORMAL which according to the sqlite documentation will leave a "very small" chance for database corruption but is than the default FULL sync mode. This commit should partially address issue mumble-voip#3254 by making database corruption much more unlikely but detecting corruption and/or handling DB backups are further possible approaches if this change turns out to have unacceptable performance or we get further reports of durability issues with the clientside DB.
hacst
force-pushed
the
clientdbdurability
branch
from
222d9df
to
12de49e
Compare
hacst
changed the title
Natenom
approved these changes
Oct 22, 2017
|
Thanks. If we see any user reports of client lags/slowdowns due to this we'll have to re-evaluate but I think we should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a userbase of primarily gamers system instabilities aren't
that uncommon. Without synchronization of the user-db this can
lead to corruption of our client database storing the
user-certificate. We have had various reports of such issues
over time.
The current mode was set in 2010 in commit 9fee66e to speed
up the client-db "even more" though it is unclear whether we
actually had performance problems that required this step.
This patch switches the client synchronization mode from OFF
to NORMAL which according to the sqlite documentation will
leave a "very small" chance for database corruption but is
than the default FULL sync mode.
This commit should partially address issue #3254 by making
database corruption much more unlikely but detecting
corruption and/or handling DB backups are further possible
approaches if this change turns out to have unacceptable
performance or we get further reports of durability issues
with the clientside DB.