Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectDialog: enable "Edit" button's AutoDefault property #3417

Closed
wants to merge 1 commit into from
Closed

ConnectDialog: enable "Edit" button's AutoDefault property #3417

wants to merge 1 commit into from

Conversation

davidebeatrici
Copy link
Member

Requested in #3410.

@davidebeatrici davidebeatrici requested review from mkrautz, Kissaki, a user and hacst June 5, 2018 17:48
@hacst
Copy link
Contributor

hacst commented Jun 14, 2018

Wouldn't we have to auto-default all the buttons to get the desired behaviour?

@davidebeatrici
Copy link
Member Author

It was requested only for the Edit button.

@Kissaki
Copy link
Member

Kissaki commented Jul 21, 2018

Can your commits and PRs please be self contained and explanatory? The commit should explain why it is changed/set this way.

@Kissaki
Copy link
Member

Kissaki commented Jul 21, 2018

So I hate to have this discussion all over the place, but this doesn't seem to make sense. All buttons should behave the same.

I can already use ALT+E to open the edit dialog. This seems to be about being able to use ENTER (which is my guess because you did not even share your intent here), but why should that only be enabled for a single button??

Kissaki
Kissaki requested changes Jul 21, 2018
View reviewed changes
Copy link
Member

@Kissaki Kissaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@davidebeatrici davidebeatrici mentioned this pull request Apr 15, 2020
Closed
@Krzmbrzl
Copy link
Member

I just verified that Alt+E does trigger the edit button. Therefore I think this PR is unneeded.

If you think differently, let me know, but for now I'll close it...

@Krzmbrzl Krzmbrzl closed this Apr 30, 2020
@Hartmnt Hartmnt added the accessibility Everything related to accessibility-features (like screen-readers) label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kissaki Kissaki Kissaki requested changes

@mkrautz mkrautz Awaiting requested review from mkrautz

@hacst hacst Awaiting requested review from hacst

Assignees
No one assigned
Labels
accessibility Everything related to accessibility-features (like screen-readers) client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidebeatrici @hacst @Kissaki @Krzmbrzl @Hartmnt