Messages: revamp channel join/leave logic and add "User connected and entered channel." message #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidebeatrici
commented
Jun 24, 2018
davidebeatrici
commented
- A new message "User connected and entered channel." has been added, in order to distinguish when a user joins the server and when it moves to the channel
- The "User joined channel" sound is reproduced when a user joins the server and enters the same channel as the client
- When moving a user, there are no longer duplicate messages, such as: "You moved User into Channel." and "User moved to Channel by You."
- The message "User moved to Channel by the server." no longer appears, when the user connects to the server and is moved to the last channel he was in.
davidebeatrici
changed the title
davidebeatrici
force-pushed
the
messages-channel-join-leave
branch
2 times, most recently
from
ced8c3f
to
8263065
Compare
Natenom
approved these changes
Jul 4, 2018
- A new message "User connected and entered channel." has been added, in order to distinguish when a user joins the server and when it moves to the channel - The "User joined channel" sound is reproduced when a user joins the server and enters the same channel as the client - When moving a user, there are no longer duplicate messages, such as: "You moved User into Channel." and "User moved to Channel by You." - The message "User moved to Channel by the server." no longer appears, when the user connects to the server and is moved to the last channel he was in.
Updating 'mumble_en.ts'...
Found 1706 source text(s) (1 new and 1705 already existing)
davidebeatrici
force-pushed
the
messages-channel-join-leave
branch
from
8263065
to
7632305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.