Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: revamp channel join/leave logic and add "User connected and entered channel." message #3426

Merged

Conversation

@davidebeatrici
Copy link
Member

commented Jun 24, 2018

  • A new message "User connected and entered channel." has been added, in order to distinguish when a user joins the server and when it moves to the channel
  • The "User joined channel" sound is reproduced when a user joins the server and enters the same channel as the client
  • When moving a user, there are no longer duplicate messages, such as: "You moved User into Channel." and "User moved to Channel by You."
  • The message "User moved to Channel by the server." no longer appears, when the user connects to the server and is moved to the last channel he was in.

@davidebeatrici davidebeatrici changed the title Messages channel join leave Messages: revamp channel join/leave logic and add "User connected and entered channel." message Jun 25, 2018

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:messages-channel-join-leave branch 2 times, most recently from ced8c3f to 8263065 Jun 25, 2018

@davidebeatrici davidebeatrici requested a review from Natenom Jul 4, 2018

@Natenom
Natenom approved these changes Jul 4, 2018
Messages: revamp channel join/leave logic
- A new message "User connected and entered channel." has been added, in order to distinguish when a user joins the server and when it moves to the channel
- The "User joined channel" sound is reproduced when a user joins the server and enters the same channel as the client
- When moving a user, there are no longer duplicate messages, such as: "You moved User into Channel." and "User moved to Channel by You."
- The message "User moved to Channel by the server." no longer appears, when the user connects to the server and is moved to the last channel he was in.
Translation update
Updating 'mumble_en.ts'...
    Found 1706 source text(s) (1 new and 1705 already existing)

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:messages-channel-join-leave branch from 8263065 to 7632305 Jul 5, 2018

@davidebeatrici davidebeatrici merged commit 1098afc into mumble-voip:master Jul 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.