Use qInfo instead of qFatal for normal logging #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason qFatal has been used to log information such as the version requested by the --version argument. abdb500 made qFatal exit with an exit status of one leading to successful operations that happened to contain some print-out to leave an exit status of 1 (mumble-voip#3911).
Kissaki
approved these changes
Mar 18, 2020
sudoforge
pushed a commit
to sudoforge/docker-mumble-server
that referenced
this pull request
Jan 31, 2021
Using -supw currently throws a fatal error and exits the program. It has been fixed in the upstream project by commit d8203ba94 [1], but has not yet been included in a release. To bypass the issue and allow the entrypoint script to proceed, we are ignoring the erroneous exit code by executing `true` if the invocation fails. This was previously fixed in commit b1229e0, but was erroneously removed in commit b7a0867. Care should be taken to ensure the upstream release _actually_ contains the fix before reverting this commit. [1]: mumble-voip/mumble@d8203ba closes #121 references #92 mumble-voip/mumble#3911 mumble-voip/mumble#3998 mumble-voip/mumble#4728
sudoforge
pushed a commit
to sudoforge/docker-mumble-server
that referenced
this pull request
Jan 31, 2021
Using -supw currently throws a fatal error and exits the program. It has been fixed in the upstream project by commit d8203ba94 [1], but has not yet been included in a release. To bypass the issue and allow the entrypoint script to proceed, we are ignoring the erroneous exit code by executing `true` if the invocation fails. This was previously fixed in commit b1229e0, but was erroneously removed in commit b7a0867. Care should be taken to ensure the upstream release _actually_ contains the fix before reverting this commit. [1]: mumble-voip/mumble@d8203ba closes #121 references #92 mumble-voip/mumble#3911 mumble-voip/mumble#3998 mumble-voip/mumble#4728
Krzmbrzl
added a commit
that referenced
this pull request
Feb 6, 2021
…ormal logging" For some reason qFatal has been used to log information such as the version requested by the --version argument. abdb500 made qFatal exit with an exit status of one leading to successful operations that happened to contain some print-out to leave an exit status of 1 (#3911). Note: This is a backport of #3998
sudoforge
pushed a commit
to sudoforge/docker-mumble-server
that referenced
this pull request
Feb 10, 2021
… failure" This reverts commit 2053b04. ``` ➜ git log --grep "$(git log -1 --format='%s' d8203ba94d528b092e0ff5a52a51af28f8f592f1)" refs/tags/1.3.4 commit 9fc1c188cf23612e0a2083af20735c1ee1571a07 Author: Robert Adam <dev@robert-adam.de> Date: Wed Mar 18 12:52:20 2020 +0100 src/murmur/main.cpp: Use qInfo instead of qFatal for normal logging. For some reason qFatal has been used to log information such as the version requested by the --version argument. abdb5004bb92b28271673e33df9cc3e314f5711a made qFatal exit with an exit status of one leading to successful operations that happened to contain some print-out to leave an exit status of 1 (#3911). ``` This was further verified by inspecting commit 9fc1c188cf23612e0a2083af20735c1ee1571a07 manually to ensure it contained the appropriate delta. refs #121 mumble-voip/mumble#3911 mumble-voip/mumble#3998 mumble-voip/mumble#4728
sudoforge
pushed a commit
to sudoforge/docker-mumble-server
that referenced
this pull request
Feb 10, 2021
… failure" This reverts commit 2053b04. ``` ➜ git log --grep "$(git log -1 --format='%s' d8203ba94d528b092e0ff5a52a51af28f8f592f1)" refs/tags/1.3.4 commit 9fc1c188cf23612e0a2083af20735c1ee1571a07 Author: Robert Adam <dev@robert-adam.de> Date: Wed Mar 18 12:52:20 2020 +0100 src/murmur/main.cpp: Use qInfo instead of qFatal for normal logging. For some reason qFatal has been used to log information such as the version requested by the --version argument. abdb5004bb92b28271673e33df9cc3e314f5711a made qFatal exit with an exit status of one leading to successful operations that happened to contain some print-out to leave an exit status of 1 (#3911). ``` This was further verified by inspecting commit 9fc1c188cf23612e0a2083af20735c1ee1571a07 manually to ensure it contained the appropriate delta. refs #121 mumble-voip/mumble#3911 mumble-voip/mumble#3998 mumble-voip/mumble#4728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason qFatal has been used to log information such as the
version requested by the --version argument.
abdb500 made qFatal exit with an
exit status of one leading to successful operations that happened
to contain some print-out to leave an exit status of 1.
Fixes #3911