Backport "Fix echo cancellation bug + add command line option to dump AudioInput streams" #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
force-pushed
the
1.3.x
branch
6 times, most recently
from
7f9c263
to
57605b8
Compare
…nput audio data and echo canceller queue state (Backported from mumble-voip#4167 and adapted to work with 1.3.x)
I guess we do not compile this code-path in any of our regular builds so it has started to rot.
Updating 'mumble_en.ts'...
Found 1719 source text(s) (5 new and 1714 already existing)
Removed 4 obsolete entries
davidebeatrici
approved these changes
May 28, 2020
|
Turns out that backporting isn't really possible due to the ancient Whoever wants to use the echo canceller fixes should use 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #4167
Furthermore it also backports 0f58796 as this fixes a extraneous parenthesis in the code.